[chore] upgrade to Node.js 20 #9466

kavilla · 2025-02-28T10:41:49Z

Description

Upgrading the Node.js version used from 18.x to the latest LTS version 20.x.

Issues Resolved

closes #8463

Screenshot

n/a

Testing the changes

local and ci

Changelog

fix: upgrade to Node.js v20

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2025-02-28T10:42:24Z

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 9466.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

kavilla · 2025-02-28T10:43:43Z

what to see how far the automation gets

codecov · 2025-02-28T10:58:40Z

Codecov Report

Attention: Patch coverage is 69.23077% with 16 lines in your changes missing coverage. Please review.

Project coverage is 61.79%. Comparing base (6cf85af) to head (a79e471).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
.../data_source_management/public/components/utils.ts	33.33%	3 Missing and 1 partial ⚠️
.../public/query/query_string/query_string_manager.ts	66.66%	2 Missing and 1 partial ⚠️
..._source_management/framework/utils/use_polling.tsx	33.33%	2 Missing ⚠️
...ver/src/lib/indices/opensearch_dashboards_index.ts	0.00%	1 Missing ⚠️
...ckages/osd-opensearch-archiver/src/lib/progress.ts	0.00%	1 Missing ⚠️
packages/osd-optimizer/src/node/cache.ts	0.00%	1 Missing ⚠️
src/core/server/http/base_path_proxy_server.ts	0.00%	1 Missing ⚠️
src/core/server/metrics/metrics_service.ts	0.00%	1 Missing ⚠️
.../docker_generator/templates/dockerfile.template.ts	0.00%	1 Missing ⚠️
...query_string/language_service/lib/query_result.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9466      +/-   ##
==========================================
- Coverage   61.81%   61.79%   -0.02%     
==========================================
  Files        3825     3825              
  Lines       92058    92068      +10     
  Branches    14602    14604       +2     
==========================================
- Hits        56902    56892      -10     
- Misses      31482    31502      +20     
  Partials     3674     3674

Flag	Coverage Δ
Linux_1	`28.94% <7.14%> (-0.01%)`	⬇️
Linux_2	`56.30% <46.15%> (-0.08%)`	⬇️
Linux_3	`39.42% <65.00%> (+<0.01%)`	⬆️
Linux_4	`28.84% <9.67%> (-0.01%)`	⬇️
Windows_1	`28.96% <7.14%> (-0.01%)`	⬇️
Windows_2	`56.26% <46.15%> (-0.08%)`	⬇️
Windows_3	`39.43% <65.00%> (+<0.01%)`	⬆️
Windows_4	`28.84% <9.67%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

angle943 · 2025-03-17T18:57:10Z

package.json

    "osd:ciGroup13": "echo \"cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/03/*.spec.js\"",
    "osd:ciGroup14": "echo \"cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/04/*.spec.js\"",
    "osd:ciGroup15": "echo \"cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/05/*.spec.js\"",
+    "osd:ciGroup16": "echo \"cypress/integration/core_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/01/saved_search.spec.js\"",


is this and above change for osd:ciGroup10 a temporary thing that you will revert, or you think it should be permanent?

github-actions · 2025-03-18T01:33:29Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-18T03:25:27Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-18T19:38:59Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-18T23:08:59Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-19T01:00:20Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-19T02:27:04Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-19T04:58:30Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-19T05:44:52Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-19T19:40:44Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-20T19:43:40Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-20T20:04:33Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-20T20:10:28Z

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

github-actions · 2025-03-20T20:11:50Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-03-20T20:12:46Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-03-20T20:13:34Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-03-20T20:17:42Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "breaking". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-03-20T20:22:00Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

github-actions · 2025-03-20T20:35:29Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-20T20:38:20Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Signed-off-by: Kawika Avilla <[email protected]> Upgrade APM node Signed-off-by: Kawika Avilla <[email protected]> build with plugins workflow Signed-off-by: Kawika Avilla <[email protected]> add on push Signed-off-by: Kawika Avilla <[email protected]> plugins Signed-off-by: Kawika Avilla <[email protected]> dont run on image Signed-off-by: Kawika Avilla <[email protected]> just use node for plugin_helpers Signed-off-by: Kawika Avilla <[email protected]> unzip Signed-off-by: Kawika Avilla <[email protected]> unzip and then untar Signed-off-by: Kawika Avilla <[email protected]> create directory Signed-off-by: Kawika Avilla <[email protected]> updates Signed-off-by: Kawika Avilla <[email protected]> pwd Signed-off-by: Kawika Avilla <[email protected]> resolve to newer browserify rsa to avoid deprecation warning, Signed-off-by: Kawika Avilla <[email protected]> ensure encoding on filesync and also no hyphen for utf8 Signed-off-by: Kawika Avilla <[email protected]> handle node issues Signed-off-by: Kawika Avilla <[email protected]> build osd-pm Signed-off-by: Kawika Avilla <[email protected]> to string utf8 Signed-off-by: Kawika Avilla <[email protected]> tostring utf8 Signed-off-by: Kawika Avilla <[email protected]> Upgrading `opensearch` client to 3.x (#9139) update dependencies Signed-off-by: Kawika Avilla <[email protected]> dont expect error Signed-off-by: Kawika Avilla <[email protected]> ignore hapi Signed-off-by: Kawika Avilla <[email protected]> restore polyfill after slight downgrade of typescript Signed-off-by: Kawika Avilla <[email protected]> fix tests Signed-off-by: Kawika Avilla <[email protected]> fix yarn lock file Signed-off-by: Kawika Avilla <[email protected]> update jest Signed-off-by: Kawika Avilla <[email protected]> remove ts jest and add module resolver Signed-off-by: Kawika Avilla <[email protected]> restore tests Signed-off-by: Kawika Avilla <[email protected]> skip test for now Signed-off-by: Kawika Avilla <[email protected]> fix caniuse Signed-off-by: Kawika Avilla <[email protected]> fix lock file Signed-off-by: Kawika Avilla <[email protected]> update workflow to run faster Signed-off-by: Kawika Avilla <[email protected]> skip test per suggestion Signed-off-by: Kawika Avilla <[email protected]> some optimizations Signed-off-by: Kawika Avilla <[email protected]> restore chromium Signed-off-by: Kawika Avilla <[email protected]> fix regex Signed-off-by: Kawika Avilla <[email protected]> set limits for heap Signed-off-by: Kawika Avilla <[email protected]> bump types and cypress Signed-off-by: Kawika Avilla <[email protected]> bump semi space size Signed-off-by: Kawika Avilla <[email protected]> revert node types bump Signed-off-by: Kawika Avilla <[email protected]> update lock file and cypress workflow Signed-off-by: Kawika Avilla <[email protected]> wait until visible Signed-off-by: Kawika Avilla <[email protected]> split it out for 15 as well Signed-off-by: Kawika Avilla <[email protected]> add a wait Signed-off-by: Kawika Avilla <[email protected]> escape and make wait a command Signed-off-by: Kawika Avilla <[email protected]> set max semi space as well Signed-off-by: Kawika Avilla <[email protected]> skip problematic tests Signed-off-by: Kawika Avilla <[email protected]> skip recents Signed-off-by: Kawika Avilla <[email protected]> cypress string update and some clean up Signed-off-by: Kawika Avilla <[email protected]> clean up build plugins workflow Signed-off-by: Kawika Avilla <[email protected]>

Signed-off-by: Kawika Avilla <[email protected]>

github-actions · 2025-03-20T20:52:20Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

github-actions · 2025-03-20T21:13:54Z

📊 Bundle Size crossed 5% for below plugins

pageLoadAssetSizeVariation:
discover: 9

virajsanghvi · 2025-03-21T15:59:48Z

cypress.config.ts

+  viewportWidth: 1920,
+  viewportHeight: 1080,


Effort to save memory?

more so 2000 x 1320 seems non standard aspect ratio

where as 1920 x 1080 being 16x9 to potentially avoid any visual oddities

virajsanghvi · 2025-03-21T16:08:26Z

package.json

  },
  "engines": {
-    "node": ">=14.20.1 <19",
+    "node": ">=14.20.1 <21",


Are we still supporting < 20?

some light testing seems like it technically can. at least no worse than it was before.

however, i believe for 20 < it will become not compatible

@ashwin-pc We're good to drop compatibility for node < 20, right? I think its more preferrable to remove and add back in later if necessary vs keep and have to maintain for all of 3.x (even if we can validate its fine through node 14 for now).

I agree. Lets remove it.

virajsanghvi

approving as node version question can be decided on later, but let's make sure we close it before 4/1

…pId$ Partially revert opensearch-project#9466. Current implementation doesn't work because QueryStringManager is constructed during setup, and setApplication happens during start. In playground or any instance we see `Could not subscribe to application.currentAppId$` in console warning. Signed-off-by: Joshua Li <[email protected]>

github-actions bot added the distinguished-contributor label Feb 28, 2025

github-actions bot added the failed changeset label Feb 28, 2025

kavilla added the nodejs 🍭 issues related to nodejs client label Feb 28, 2025

kavilla linked an issue Mar 1, 2025 that may be closed by this pull request

[Node.js v20] Plugin Verification Meta Issue #9459

Closed

16 tasks

kavilla force-pushed the feature/node-2x branch from 6e980e8 to 1fe1bc8 Compare March 1, 2025 12:54

kavilla mentioned this pull request Mar 4, 2025

[chore] update caniuse and fix some things in cypress #9483

Open

7 tasks

peterzhuamazon mentioned this pull request Mar 4, 2025

[RELEASE] Release version 3.0.0 opensearch-project/opensearch-build#3747

Closed

66 tasks

kavilla force-pushed the feature/node-2x branch 3 times, most recently from cf55915 to 59f6c34 Compare March 7, 2025 22:53

kavilla force-pushed the feature/node-2x branch from 1e9c400 to 505d2cd Compare March 14, 2025 00:09

angle943 reviewed Mar 17, 2025

View reviewed changes

kavilla force-pushed the feature/node-2x branch from bdcdc72 to df75f74 Compare March 18, 2025 19:12

kavilla force-pushed the feature/node-2x branch from df75f74 to 2f2e05b Compare March 18, 2025 22:42

kavilla marked this pull request as ready for review March 19, 2025 06:51

kavilla requested review from AMoo-Miki, ananzh, ashwin-pc and joshuarrrr as code owners March 19, 2025 06:51

kavilla force-pushed the feature/node-2x branch from 7c226c2 to 18afb17 Compare March 20, 2025 19:17

kavilla force-pushed the feature/node-2x branch from b304179 to 10bfa97 Compare March 20, 2025 20:26

kavilla added 2 commits March 20, 2025 20:44

fix lock file linter issues

a79e471

Signed-off-by: Kawika Avilla <[email protected]>

kavilla force-pushed the feature/node-2x branch from 10bfa97 to a79e471 Compare March 20, 2025 20:47

zhongnansu approved these changes Mar 21, 2025

View reviewed changes

virajsanghvi reviewed Mar 21, 2025

View reviewed changes

virajsanghvi approved these changes Mar 21, 2025

View reviewed changes

kavilla merged commit 4ef7f0b into main Mar 24, 2025
75 of 76 checks passed

peterzhuamazon mentioned this pull request Mar 25, 2025

Update 3.0.0-beta1 osd core branch to main in manifests opensearch-project/opensearch-build#5424

Merged

pearsondavid mentioned this pull request Sep 11, 2025

wazuh-dashboard uses an outdated version of node.js wazuh/wazuh-dashboard#523

Closed

chenrui333 mentioned this pull request Nov 1, 2025

Support node 24 #10841

Open

joshuali925 mentioned this pull request Nov 20, 2025

fix(QueryStringManager): fix Could not subscribe to application.currentAppId$ #10943

Closed

7 tasks

[chore] upgrade to Node.js 20 #9466

[chore] upgrade to Node.js 20 #9466

Uh oh!

Conversation

kavilla commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Uh oh!

github-actions bot commented Feb 28, 2025

ℹ️ Manual Changeset Creation Reminder

Uh oh!

kavilla commented Feb 28, 2025

Uh oh!

codecov bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

angle943 Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 19, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Changelog Entry Missing Hyphen

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

❌ Invalid Prefix For Manual Changeset Creation

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

virajsanghvi Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

kavilla Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

kavilla commented Feb 28, 2025 •

edited

Loading

codecov bot commented Feb 28, 2025 •

edited

Loading