Skip to content

Conversation

@joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Nov 20, 2025

Description

Partially revert #9466. Current implementation doesn't work because QueryStringManager is constructed during setup, and setApplication happens during start. In playground or any instance we see Could not subscribe to application.currentAppId$ in console warning.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: fix Could not subscribe to application.currentAppId$

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@github-actions
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "fix(QueryStringManager)". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

opensearch-changeset-bot bot added a commit to joshuali925/OpenSearch-Dashboards that referenced this pull request Nov 20, 2025
…pId$

Partially revert opensearch-project#9466. Current implementation doesn't work because
QueryStringManager is constructed during setup, and setApplication
happens during start. In playground or any instance we see `Could not
subscribe to application.currentAppId$` in console warning.

Signed-off-by: Joshua Li <[email protected]>
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.78%. Comparing base (7f80625) to head (ca2656f).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../public/query/query_string/query_string_manager.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10943   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files        4531     4531           
  Lines      122235   122232    -3     
  Branches    20491    20491           
=======================================
- Hits        74301    74300    -1     
+ Misses      42695    42693    -2     
  Partials     5239     5239           
Flag Coverage Δ
Linux_1 26.56% <0.00%> (+<0.01%) ⬆️
Linux_2 38.92% <ø> (ø)
Linux_3 39.49% <83.33%> (+<0.01%) ⬆️
Linux_4 33.74% <0.00%> (+<0.01%) ⬆️
Windows_1 26.57% <0.00%> (+<0.01%) ⬆️
Windows_2 38.90% <ø> (ø)
Windows_3 39.49% <83.33%> (+<0.01%) ⬆️
Windows_4 33.74% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joshuali925
Copy link
Member Author

this revert is not a good fix, because getCurrentAppId called during setup still cannot get appId. It only fixes when calls are after setup. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant