[chore] update caniuse and fix some things in cypress #9483
Conversation
Caniuse out of date cause one of our tests to fail because it does a raw compare and sees the caniuse complaint. Also, returning back a promise and then doing stuff in the save search spec. Also just bumping up the timeout for the get elements just to give it more of a chance. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9483 +/- ##
==========================================
+ Coverage 61.74% 61.75% +0.01%
==========================================
Files 3816 3816
Lines 91885 91885
Branches 14564 14564
==========================================
+ Hits 56735 56745 +10
+ Misses 31493 31482 -11
- Partials 3657 3658 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| return postRequestSaveSearch(config).then(() => { | ||
| updateSavedSearchAndSaveAndVerify(config, workspaceName, DATASOURCE_NAME, true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
why was this change needed? Your description says something about bumping the timeout, but is this section related to that?
| baseUrl: 'http://localhost:5601', | ||
| specPattern: 'cypress/integration/**/*.spec.{js,jsx,ts,tsx}', | ||
| testIsolation: false, | ||
| testIsolation: true, |
There was a problem hiding this comment.
previously i was wondering why this was set to false. If tests pass then yeah this should be set to true.
But to give some background knowledge. In other environments we set this to false. This is because some of our tests require authentication and that does not persist if this is set to true
| return cy.get('@INDEX_PATTERN_ID').then((indexPatternId) => { | ||
| // POST a saved search | ||
| cy.request({ | ||
| return cy.request({ |
There was a problem hiding this comment.
i wasn't originally seeing things wait for the saved search to load which should be async so i'm returning the promise chain so that then we can chain off the response and then proceed to validate. but i could be missing a wait from intercepting somehting.
| }); | ||
| Cypress.Commands.add( | ||
| 'getElementByTestIdLike', | ||
| (testId, options = { timeout: Cypress.config('defaultCommandTimeout') }) => { |
There was a problem hiding this comment.
there should be a way to just type the options so that it has all the things that the usual options for cy.get() has. This way if we ever need to add more stuff in the future, we don't need to explictely update the typing
There was a problem hiding this comment.
i think you already set this value at the cypress config level so i was kind of shooting in the dark with this one and can prolly remove not positive if the option will be passed down nested levels would make sense to me. but basically anyone could override it. unless you are trying to say it would be better to have a set an options that we would let people set and not let them configure it past that
Signed-off-by: Kawika Avilla <[email protected]>
| viewportWidth: 1920, | ||
| viewportHeight: 1080, |
There was a problem hiding this comment.
Do we have any screenshot comparisons we have to worry about breaking here?
| // using a POST request to create a saved search to load | ||
| postRequestSaveSearch(config); | ||
| updateSavedSearchAndSaveAndVerify(config, workspaceName, DATASOURCE_NAME, false); | ||
| cy.wrap(null).then(() => { |
There was a problem hiding this comment.
Is this to ensure that the async operations are completed before continuing to the assertions?
3 participants
Description
Caniuse out of date cause one of our tests to fail because it does a raw compare and sees the caniuse complaint.
Also, returning back a promise and then doing stuff in the save search spec.
Also just bumping up the timeout for the get elements just to give it more of a chance.
Issues Resolved
n/a
Screenshot
n/a
Testing the changes
#9466
Changelog
Check List
yarn test:jestyarn test:jest_integration