Prefer System getProperty() over getenv()

[Akanksha928]

What's changed?

Added a new recipe that replaces 'System.getenv("HOME")' with 'System.getProperty("user.home")'.

What's your motivation?

• Draft PR for Prefer System getProperty() over getenv() #624

Anything in particular you'd like reviewers to focus on?

Nothing in specific

Have you considered any alternatives or workarounds?

Not yet, but open to discussion

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Akanksha928]

I've made the requested changes!

[greg-at-moderne]

I think you can extend it now for other cases.
ChatGPT suggests:
(left hand side is getenv, right hand side is getProperty)

• USERNAME/USER => user.name
• HOME/USERPROFILE => user.home
• TMPDIR/TEMP/TMP => java.io.tmpdir

[Akanksha928]

Got it, sure

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/staticanalysis/BooleanChecksNotInvertedTest.java
  • lines 27-27
  • lines 64-64
• src/test/java/org/openrewrite/staticanalysis/SimplifyTernaryTest.java
  • lines 25-25
  • lines 91-91

[timtebeek]

Thanks a lot for the help & rework here @Akanksha928 ! Seems like a perfect addition to the catalog.

I've applied some minor polish to your PR on the following points:

• No need to check the number of arguments: that's implied by MethodMatcher
• No need to check the type of the value returned by the Literal; again implied
• No need to add imports for java.lang entries; those are always present
• Then no need to use JavaTemplate builder, as there's a shorthand to directly apply

Note that we don't expect you to know all this when starting out; just sharing here as it might help you learn, as we'd love to see what else you will build. :)