fix: Enhanced UseCollectionInterfaces to prevent conversions when non interface methods are used

[e5LA]

What's changed?

Enhanced UseCollectionInterfaces recipe to prevent type conversions when concrete-class-specific methods are being used.
Also, added support for java.util.Vector

What's your motivation?

• Closes UseCollectionInterfaces does not check for method calls not defined on the Interface type #688
• Fixes UseCollectionInterfaces changes type of variable passed as parameter to method in other compilation unit #671

Anything in particular you'd like reviewers to focus on?

• The nonInterfaceMethods to ensure we've covered all the important methods
• Two-phase approach, ie first detect and then transform. Whether this is the most efficient way

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/UseCollectionInterfaces.java
  • lines 27-35

[timtebeek]

Thanks a lot for the clear fix here @e5LA ! I've simplified your approach a bit, but kept things functionally the same. Specifically you can pass in any second argument to your new visitor. An AtomicBoolean seemed the best fit. Also when you then do not call super.visit(Tree,...) there's no need for guards in your other visit methods, as those will not get called. Finally I found another disabled unit test that can be fixed with a small addition for a dual fix here. Great!

[e5LA]

Thanks @timtebeek for the review and the improvements! Your changes are elegant and more efficient, the reducer pattern is much cleaner. Appreciate you taking the time to show the proper OpenRewrite patterns.

And great we could close two issues with this one PR 👍