Prefer System getProperty() over getenv()

src/main/java/org/openrewrite/staticanalysis/PreferSystemGetPropertyOverGetenv.java

@@ -0,0 +1,75 @@
+/*
+ * Copyright 2025 the original author or authors.
+ * <p>
+ * Licensed under the Moderne Source Available License (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * https://docs.moderne.io/licensing/moderne-source-available-license
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.openrewrite.staticanalysis;
+
+import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
+import org.openrewrite.Recipe;
+import org.openrewrite.TreeVisitor;
+import org.openrewrite.java.JavaIsoVisitor;
+import org.openrewrite.java.JavaTemplate;
+import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
+import org.openrewrite.java.tree.J;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class PreferSystemGetPropertyOverGetenv extends Recipe {
+
+    private static final MethodMatcher GETENV = new MethodMatcher("java.lang.System getenv(java.lang.String)");
+    private static final Map<String, String> ENV_TO_PROPERTY = new HashMap<>();
+
+    static {
+        ENV_TO_PROPERTY.put("USER", "user.name");
+        ENV_TO_PROPERTY.put("USERNAME", "user.name");
+        ENV_TO_PROPERTY.put("HOME", "user.home");
+        ENV_TO_PROPERTY.put("USERPROFILE", "user.home");
+        ENV_TO_PROPERTY.put("TMPDIR", "java.io.tmpdir");
+        ENV_TO_PROPERTY.put("TEMP", "java.io.tmpdir");
+        ENV_TO_PROPERTY.put("TMP", "java.io.tmpdir");
+    }
+
+    @Override
+    public String getDisplayName() {
+        return "Prefer `System.getProperty(\"user.home\")` over `System.getenv(\"HOME\")`";
+    }
+
+    @Override
+    public String getDescription() {
+        return "Replaces `System.getenv(\"HOME\")` with `System.getProperty(\"user.home\")` for better portability.";
+    }
+
+    @Override
+    public TreeVisitor<?, ExecutionContext> getVisitor() {
+        return Preconditions.check(new UsesMethod<>(GETENV), new JavaIsoVisitor<ExecutionContext>() {
+            @Override
+            public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
+                if (GETENV.matches(method) && method.getArguments().get(0) instanceof J.Literal) {
+                    String value = (String) ((J.Literal) method.getArguments().get(0)).getValue();
+                    String replacementProperty = ENV_TO_PROPERTY.get(value);
+                    if (replacementProperty != null) {
+                        return JavaTemplate.apply(
+                                "System.getProperty(\"" + replacementProperty + "\")",
+                                getCursor(),
+                                method.getCoordinates().replace());
+                    }
+                }
+                return super.visitMethodInvocation(method, ctx);
+            }
+        });
+    }
+}

src/main/resources/META-INF/rewrite/common-static-analysis.yml

@@ -65,6 +65,7 @@ recipeList:
   - org.openrewrite.staticanalysis.NoToStringOnStringType
   - org.openrewrite.staticanalysis.NoValueOfOnStringType
   - org.openrewrite.staticanalysis.ObjectFinalizeCallsSuper
+  - org.openrewrite.staticanalysis.PreferSystemGetPropertyOverGetenv
   - org.openrewrite.staticanalysis.PrimitiveWrapperClassConstructorToValueOf
   - org.openrewrite.staticanalysis.RedundantFileCreation
   - org.openrewrite.staticanalysis.RemoveExtraSemicolons

src/test/java/org/openrewrite/staticanalysis/PreferSystemGetPropertyOverGetenvTest.java

@@ -0,0 +1,66 @@
+/*
+ * Copyright 2025 the original author or authors.
+ * <p>
+ * Licensed under the Moderne Source Available License (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * https://docs.moderne.io/licensing/moderne-source-available-license
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.openrewrite.staticanalysis;
+
+import org.junit.jupiter.api.Test;
+import org.openrewrite.DocumentExample;
+import org.openrewrite.test.RecipeSpec;
+import org.openrewrite.test.RewriteTest;
+
+import static org.openrewrite.java.Assertions.java;
+
+class PreferSystemGetPropertyOverGetenvTest implements RewriteTest {
+
+    @Override
+    public void defaults(RecipeSpec spec) {
+        spec.recipe(new PreferSystemGetPropertyOverGetenv());
+    }
+
+    @DocumentExample
+    @Test
+    void replacesMultipleEnvVariables() {
+        rewriteRun(
+          java(
+            """
+              class A {
+                  void test() {
+                      String user = System.getenv("USER");
+                      String username = System.getenv("USERNAME");
+                      String home = System.getenv("HOME");
+                      String profile = System.getenv("USERPROFILE");
+                      String temp = System.getenv("TEMP");
+                      String tmpdir = System.getenv("TMPDIR");
+                      String tmp = System.getenv("TMP");
+                  }
+              }
+              """,
+            """
+              class A {
+                  void test() {
+                      String user = System.getProperty("user.name");
+                      String username = System.getProperty("user.name");
+                      String home = System.getProperty("user.home");
+                      String profile = System.getProperty("user.home");
+                      String temp = System.getProperty("java.io.tmpdir");
+                      String tmpdir = System.getProperty("java.io.tmpdir");
+                      String tmp = System.getProperty("java.io.tmpdir");
+                  }
+              }
+              """
+          )
+        );
+    }
+}