Skip to content

Conversation

@pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Sep 30, 2025

Which problem is this PR solving?

Similar to the PR in the contrib repo. We can use --ignore-scripts wherever possible to avoid postinstall scripts from running in CI that are not strictly needed.

Ref: open-telemetry/opentelemetry-js-contrib#3121

@pichlermarc pichlermarc requested a review from a team as a code owner September 30, 2025 09:59
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (a594098) to head (e1f6aa8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5971   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         316      316           
  Lines        8521     8521           
  Branches     1763     1763           
=======================================
  Hits         8110     8110           
  Misses        411      411           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor

maryliag commented Oct 1, 2025

how is this being tested? just wondering, so it doesn't have the same issue on the other repo where you had to revert one of the changes

@pichlermarc
Copy link
Member Author

@maryliag - in the other repo not all tests actually run on the PR, only affected packages. Since the .github directory does not affect the build, we missed the failure.

Here, we always run all tests on PRs - so there's no guesswork. 🙂

@pichlermarc
Copy link
Member Author

no guesswork

for the most part anyway. There are still some workflows that only run on main or on publish. For the most part though, we only need it for a following compile step, which we already know from tests will work 🙂

Anyway - I'm on standby for any problems that arise from this change and will fix it ASAP.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! in that case, I'll approve and let's keep an eye on it

@pichlermarc pichlermarc added this pull request to the merge queue Oct 1, 2025
Merged via the queue into open-telemetry:main with commit 9500c12 Oct 1, 2025
25 checks passed
@pichlermarc pichlermarc deleted the chore/use-ignore-scripts branch October 1, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants