-
Notifications
You must be signed in to change notification settings - Fork 954
ci: use --ignore-scripts wherever possible #5971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use --ignore-scripts wherever possible #5971
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5971 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 316 316
Lines 8521 8521
Branches 1763 1763
=======================================
Hits 8110 8110
Misses 411 411 🚀 New features to boost your workflow:
|
|
how is this being tested? just wondering, so it doesn't have the same issue on the other repo where you had to revert one of the changes |
|
@maryliag - in the other repo not all tests actually run on the PR, only affected packages. Since the Here, we always run all tests on PRs - so there's no guesswork. 🙂 |
for the most part anyway. There are still some workflows that only run on Anyway - I'm on standby for any problems that arise from this change and will fix it ASAP. |
maryliag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! in that case, I'll approve and let's keep an eye on it
Which problem is this PR solving?
Similar to the PR in the contrib repo. We can use
--ignore-scriptswherever possible to avoid postinstall scripts from running in CI that are not strictly needed.Ref: open-telemetry/opentelemetry-js-contrib#3121