ci: use --ignore-scripts wherever possible #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
approved these changes
Sep 29, 2025
Member
Author
|
Follow-up: #3122 - looks like |
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Oct 7, 2025
…to pass https://github.com/open-telemetry/opentelemetry-js-contrib/actions/workflows/test-all-versions.yml started failing last week after open-telemetry#3121. We cannot use --ignore-scripts in this case. This is the equivalent change as was done for test.yml in open-telemetry#3122.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I have checked some postinstall scripts, but they seem to mostly be for for warning users of improper usage and can therefore be safely ignored in CI. Ignoring the scripts also reduces attack surface a bit further.