chore: prefer nx over lerna where possible #5965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
force-pushed
the
chore/ditch-lerna-except-for-publishing
branch
from
218903d to
cd575d0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5965 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 316 316
Lines 8521 8521
Branches 1763 1763
=======================================
Hits 8110 8110
Misses 411 411 🚀 New features to boost your workflow:
|
pichlermarc
force-pushed
the
chore/ditch-lerna-except-for-publishing
branch
from
e14008e to
e36bb56
Compare
pichlermarc
force-pushed
the
chore/ditch-lerna-except-for-publishing
branch
from
e36bb56 to
71d60f2
Compare
pichlermarc
commented
Sep 30, 2025
Comment on lines
+45
to
+47
| "peerDependencies": { | ||
| "@opentelemetry/api": "^1.9.0" | ||
| }, |
Member
Author
There was a problem hiding this comment.
note: this was failing on the peer-api-check - I'm not sure why we did not include it for experimental packages, it should also apply to these.
Comment on lines
+22
to
+23
| - name: Install script dependencies | ||
| run: npm ci --ignore-scripts |
Member
Author
There was a problem hiding this comment.
Note: I did this here as a drive-by. Will do this where possible in a separate PR.
| "prepare_release:semconv:patch": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_patch && npm run _restore:package-json && npm run _changelog:prepare_semconv", | ||
| "prepare_release:semconv:minor": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_everything_except_semconv && npm run _lerna:version_minor && npm run _restore:package-json && npm run _changelog:prepare_semconv", | ||
| "prepare_release:all:minor": "npm run _check:no_changes && npm run _backup:package-json && npm run _lerna:remove_api && npm run _lerna:remove_semconv && npm run _lerna:version_minor && cd api/ && npm version minor && cd .. && lerna run align-api-deps && npm run _restore:package-json && npm run _changelog:prepare_all", | ||
| "prepare_release:experimental": "npm run _check:no_changes && npm run _backup:package-json && npm run _workspace:remove_api && npm run _workspace:remove_semconv && npm run _workspace:remove_stable && npm run _workspace:bump_version && npm run _restore:package-json && npm run _changelog:prepare_experimental", |
Member
Author
There was a problem hiding this comment.
note: lerna was not really necessary for these and I opted to use a custom script instead. Since we need to bump all packages in unison we were mostly working around lerna. The new script scripts/bump-versions.mjs gives us more control and allows us to simplify these scripts further in the future.
I did not go all the way as this is the minimal thing we needed to get it working without lerna :)
david-luna
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Drops
lernafornxwherever possible. This is necessary aslerna@9for publishing with OIDC, and it might not work with Node.js <20.19 - also it pulls in a newernxversion that drops support for this Node.js version.nx@20andlerna@9we can use the oldernxversion for dev and testing, and the newerlernaversion for publishing. Once we drop support for older Node.js versions, we can start using the same versions again.The setup on the
nxscripts is heavliy based on the migration work that @david-luna did in the contrib repo 🙂 A nice side-effect of this PR is that we will be closer aligned with contrib tooling.Full disclosure: I did ✨vibe-code✨ the
bump-versions.mjsscript. I think it turned out alright.