Replace deprecated golint with golang-ci lint #722
Conversation
|
Hi @tjons, Sorry for the extra PR! I ran into issues while syncing my fork’s main branch, which affected the previous PR. I’ve updated the CI workflow, and it’s running fine now. The only remaining issues are linter errors, please let me know if you have any suggestions on how to address them. Thanks again for your help! |
|
@akashsawan1 looks great! I put some thought into how to handle the new linter errors. Let's handle them as separate PRs in separate issues so we can keep the merge history clean. I've created this milestone: https://github.com/open-policy-agent/opa-envoy-plugin/milestone/1 to manage them and will work on them myself - you're more than welcome to help out too. I've disabled them with a comment to the relevant issue, so this should be good to merge now. |
tjons
force-pushed
the
feature/golangci-lint-integration
branch
from
56d6769 to
610c2e7
Compare
- Add .golangci.yaml for linting, following the OPA project approach. - Update Makefile to use golangci-lint (v1.64.5). Signed-off-by: Akash Sawan <[email protected]> refactor: remove check-lint.sh, check-vet.sh, check-fmt.sh, and golint package Signed-off-by: Akash Sawan <[email protected]> ci: switch to `make check` in CI workflow and increase timeout - Updated CI workflow to use `make check` instead of `make ci-go-check`, following the OPA project approach. - Previously, `ci-go-check` required spinning up a Go Docker environment on the first run; this is no longer needed with `make check`. - Increased job timeout from 15 to 30 minutes to allow more time for linting, following the OPA project. Signed-off-by: Akash Sawan <[email protected]> Signed-off-by: tjons <[email protected]>
tjons
force-pushed
the
feature/golangci-lint-integration
branch
from
610c2e7 to
5c91a05
Compare
tjons
left a comment
tjons
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
…agent#722) - Add .golangci.yaml for linting, following the OPA project approach. - Update Makefile to use golangci-lint (v1.64.5). refactor: remove check-lint.sh, check-vet.sh, check-fmt.sh, and golint package ci: switch to `make check` in CI workflow and increase timeout - Updated CI workflow to use `make check` instead of `make ci-go-check`, following the OPA project approach. - Previously, `ci-go-check` required spinning up a Go Docker environment on the first run; this is no longer needed with `make check`. - Increased job timeout from 15 to 30 minutes to allow more time for linting, following the OPA project. Signed-off-by: Akash Sawan <[email protected]> Signed-off-by: tjons <[email protected]>
2 participants
This PR resolves Replace deprecated golint with golangci-lint #709 by replacing
golintwithgolangci-lint.Changes:
.golangci.yamlfor linting configuration, aligning with the main OPA project.golangci-lint(v1.64.5) for linting.golintdependency.check-lint.sh,check-vet.sh,check-fmt.sh, and thegolintpackage.make check(replacingmake ci-go-check) and increased job timeout from 15 to 30 minutes, following the OPA project approach.ci-go-checkin the GitHub CI workflow required spinning up a Go Docker environment for linting, this is no longer needed.