feat: add golangci-lint integration and update Makefile

- Add .golangci.yaml for  linting, following the OPA project approach.
- Update Makefile to use golangci-lint (v1.64.5).

Signed-off-by: Akash Sawan <[email protected]>

refactor: remove check-lint.sh, check-vet.sh, check-fmt.sh, and golint package

Signed-off-by: Akash Sawan <[email protected]>

ci: switch to `make check` in CI workflow and increase timeout

- Updated CI workflow to use `make check` instead of `make ci-go-check`, following the OPA project approach.
- Previously, `ci-go-check` required spinning up a Go Docker environment on the first run; this is no longer needed with `make check`.
- Increased job timeout from 15 to 30 minutes to allow more time for linting, following the OPA project.

Signed-off-by: Akash Sawan <[email protected]>
Signed-off-by: tjons <[email protected]>

Author: akashsawan1

.github/workflows/checks.yaml

@@ -39,8 +39,8 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Golang Style and Lint Check
-        run: make ci-go-check
-        timeout-minutes: 15
+        run: make check
+        timeout-minutes: 30
 
   deploy:
     name: Push Latest Release

.golangci.yaml

@@ -0,0 +1,215 @@
+run:
+  timeout: 5m
+
+issues:
+  max-same-issues: 0 # don't hide issues in CI runs because they are the same type
+  exclude-dirs:
+    - internal/gojsonschema
+    - internal/jwx
+  exclude-rules:
+    - path: ast/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: bundle/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: capabilities/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: compile/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: config/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: cover/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: debug/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: dependencies/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: download/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: format/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: hooks/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: ir/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: keys/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: loader/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: logging/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: metrics/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: plugins/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: profiler/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: refactor/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: repl/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: rego/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: resolver/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: runtime/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: schemas/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: sdk/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: server/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: storage/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: tester/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: topdown/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: tracing/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: types/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: util/
+      linters:
+        - staticcheck
+      text: "SA1019"
+    - path: version/
+      linters:
+        - staticcheck
+      text: "SA1019"
+
+linters-settings:
+  lll:
+    line-length: 200
+  gocritic:
+    disabled-checks:
+      - appendAssign
+      # NOTE(ae): this one should be enabled, but there were too
+      # many violations to fix in one go... revisit later
+      - singleCaseSwitch
+      # Reasonable rule, but not sure what to replace with in
+      # many locations, so disabling for now
+      - exitAfterDefer
+      # The following 3 rules are disabled from the perfomance tag
+      # enabled further down. The first two are reasonable, but not
+      # super important. appendCombine is really nice though! And
+      # should be enabled. Just many places to fix..
+      - hugeParam
+      - preferFprint
+      - appendCombine
+    enabled-checks:
+      # NOTE that these are rules enabled in addition to the default set
+      - filepathJoin
+      - dupImport
+      - redundantSprint
+      - stringConcatSimplify
+    enabled-tags:
+      - performance
+    settings:
+      ifElseChain:
+        # ridiculous value set for now, but this should be
+        # lowered to something more reasonable, as the rule
+        # is reasonable (replace long if-else chains with
+        # switch)... just too many violations right now
+        minThreshold: 10
+  govet:
+    enable:
+      - deepequalerrors
+      - nilness
+  perfsprint:
+    # only rule disabled by default, but it's a good one
+    err-error: true
+  revive:
+    rules:
+    # this mainly complains about us using min/max for variable names,
+    # which seems like an unlikely source of actual issues
+      - name: redefines-builtin-id
+        disabled: true
+      - name: unused-receiver
+        disabled: false
+
+linters:
+  disable-all: true
+  enable:
+    - mirror
+    # - errcheck # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/723 is complete
+    # - govet # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/727 is complete
+    - ineffassign
+    # - intrange # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/728 is complete
+    # - revive # replacement for golint # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/724 is complete
+    - gofmt
+    - goimports
+    - unused
+    - misspell
+    - usetesting
+    - typecheck
+    - staticcheck
+    # - gosimple # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/726 is complete
+    - prealloc
+    - unconvert
+    - copyloopvar
+    # - perfsprint # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/729 is complete
+    # - gocritic # reenable after https://github.com/open-policy-agent/opa-envoy-plugin/issues/725 is complete
+    # - gosec # too many false positives

Makefile

@@ -17,6 +17,9 @@ CGO_ENABLED ?= 1
 WASM_ENABLED ?= 1
 GOARCH ?= $(shell go env GOARCH)
 
+DOCKER_RUNNING ?= $(shell docker ps >/dev/null 2>&1 && echo 1 || echo 0)
+GOLANGCI_LINT_VERSION := v1.64.5
+
 # GOPROXY=off: Don't pull anything off the network
 # see https://github.com/thepudds/go-module-knobs/blob/master/README.md
 GO := CGO_ENABLED=$(CGO_ENABLED) GOARCH=$(GOARCH) GO111MODULE=on GOFLAGS=-mod=vendor GOPROXY=off go
@@ -192,19 +195,20 @@ clean:
 	rm -f *.so
 
 .PHONY: check
-check: check-fmt check-vet check-lint
-
-.PHONY: check-fmt
-check-fmt:
-	./build/check-fmt.sh
-
-.PHONY: check-vet
-check-vet:
-	./build/check-vet.sh
+check:
+ifeq ($(DOCKER_RUNNING), 1)
+	docker run --rm -v $(shell pwd):/app:ro,Z -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v
+else
+	@echo "Docker not installed or running. Skipping golangci run."
+endif
 
-.PHONY: check-lint
-check-lint:
-	./build/check-lint.sh
+.PHONY: fmt
+fmt:
+ifeq ($(DOCKER_RUNNING), 1)
+	docker run --rm -v $(shell pwd):/app:Z -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v --fix
+else
+	@echo "Docker not installed or running. Skipping golangci run."
+endif
 
 .PHONY: generatepb
 generatepb: