Replace deprecated golint with golang-ci lint

[tjons]

It would be nice to be able to add project-specific linting rules to the repo, to avoid style conversations in PRs. https://pkg.go.dev/golang.org/x/lint is now deprecated and frozen, so we will need to find something else that supports defining a set of linters we would like to pass on PRs. https://github.com/golangci/golangci-lint is very popular and already adopted by the OPA core project, so I think a good starting place is to drop in their linter config and make the required changes to CI to ensure that golangci-lint replaces the existing functionality we depend on.

[akashsawan1]

Hi @tjons ,

In the OPA project (Makefile), golangci-lint is run via Docker and is not included in the source code.

.PHONY: check check: ifeq ($(DOCKER_RUNNING), 1) docker run --rm -v $(shell pwd):/app:ro,Z -w /app golangci/golangci-lint:${GOLANGCI_LINT_VERSION} golangci-lint run -v else @echo "Docker not installed or running. Skipping golangci run." endif

and, in this project, golint is present in the source at ./vendor/golang.org/x/lint/golint, and linting is performed using a shell function like this:

function opa-envoy-plugin::check_lint() { exec 5>&1 exit_code=0 for pkg in $(opa-envoy-plugin::go_packages); do __output=$(go run ./vendor/golang.org/x/lint/golint $pkg | tee >(cat - >&5)) if [ ! -z "$__output" ]; then exit_code=1 fi done exit $exit_code }
build/check-lint.sh

Should I switch to the Docker-based approach like OPA uses, or should I integrate golangci-lint in a way that’s similar to the current setup in this project?

would appreciate your guidance on this. Thanks!

[tjons]

Hey @akashsawan1, thanks for your interest in this issue! I think we should keep it as similar as possible to OPA. Therefore, I'd like the docker approach. Let me know if there's anything else I can do to help!