Umitools/dedup adding log and bug workaround#3526
Merged
anoronh4 merged 12 commits intonf-core:masterfrom Jun 20, 2023
Merged
Conversation
This was
linked to
issues
Jun 13, 2023
Contributor
Author
nvnieuwk
reviewed
Jun 14, 2023
…opying" This reverts commit 8b68b04.
…into umitools/dedup/enhance
nvnieuwk
approved these changes
Jun 19, 2023
Contributor
nvnieuwk
left a comment
There was a problem hiding this comment.
Nice! This is perfect! Can you also quickly add a stub section before merging? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes issue #3504: Stages input bam and bai in a subfolder using stageAs, in order to prevent the inputs from matching the wildcard in the bam output channel.
Closes issue #3505: Added log file parameter and output channel, and updated all pytests to check for the log file output.
This PR was created to combine PRs #3506 and #3507, based on a suggestion that the two PRs should be combined for easier review. Those PRs are now closed.
versions.ymlfile.labelPROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-awarePROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware