Skip to content

Umitools/dedup adding log and bug workaround#3526

Merged
anoronh4 merged 12 commits intonf-core:masterfrom
anoronh4:umitools/dedup/enhance
Jun 20, 2023
Merged

Umitools/dedup adding log and bug workaround#3526
anoronh4 merged 12 commits intonf-core:masterfrom
anoronh4:umitools/dedup/enhance

Conversation

@anoronh4
Copy link
Copy Markdown
Contributor

@anoronh4 anoronh4 commented Jun 13, 2023

PR checklist

Closes issue #3504: Stages input bam and bai in a subfolder using stageAs, in order to prevent the inputs from matching the wildcard in the bam output channel.
Closes issue #3505: Added log file parameter and output channel, and updated all pytests to check for the log file output.

This PR was created to combine PRs #3506 and #3507, based on a suggestion that the two PRs should be combined for easier review. Those PRs are now closed.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@anoronh4
Copy link
Copy Markdown
Contributor Author

anoronh4 commented Jun 13, 2023

@nvnieuwk i have combined PRs #3506 and #3507, as you suggested. Hopefully we can get this moving soon?

Comment thread modules/nf-core/umitools/dedup/main.nf Outdated
@anoronh4 anoronh4 requested a review from nvnieuwk June 16, 2023 16:53
Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is perfect! Can you also quickly add a stub section before merging? :)

@anoronh4 anoronh4 added this pull request to the merge queue Jun 20, 2023
Merged via the queue into nf-core:master with commit 7297204 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] umitools/dedup should output log for publishing and downstream analysis umitools/dedup converts input bam from symlink to hard link

2 participants