Skip to content

Add log file in output channels of umitools/dedup#3506

Closed
anoronh4 wants to merge 3 commits intonf-core:masterfrom
anoronh4:umitools/dedup/log_out
Closed

Add log file in output channels of umitools/dedup#3506
anoronh4 wants to merge 3 commits intonf-core:masterfrom
anoronh4:umitools/dedup/log_out

Conversation

@anoronh4
Copy link
Copy Markdown
Contributor

@anoronh4 anoronh4 commented Jun 8, 2023

Added log file parameter and output channel, and updated all pytests to check for the log file output.

PR checklist

Closes #3505

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@nvnieuwk
Copy link
Copy Markdown
Contributor

nvnieuwk commented Jun 9, 2023

Can you merge all changes to umitools/dedup in one PR? That will save you the hassle of having to solve merge conflicts and it's easier to review :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] umitools/dedup should output log for publishing and downstream analysis

2 participants