fix(files): let popper overflow in header #41093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsejet
force-pushed
the
fix-files-list-popper
branch
from
2c4c5b7 to
4175ac9
Compare
juliusknorr
approved these changes
Oct 24, 2023
skjnldsv
approved these changes
Oct 25, 2023
skjnldsv
added
4. to release
Member
|
Please rebase and compile :) |
juliusknorr
force-pushed
the
fix-files-list-popper
branch
from
4175ac9 to
75b8524
Compare
Member
|
/compile |
Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
fix-files-list-popper
branch
from
da1cd22 to
43b12f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #41018 (comment)
Tbh, I don't really like the popper being inside the header element because it violates the visual scope of the header. My first attempt at fixing this was to disable containment when the popper exists (easy:
has, with fallback to class on body for Firefox). But then I realised other apps might add headers doing weirder stuff and this'll eventually cause problems :(Anyway, with #40999 we no longer repaint the header unless necessary (it's never destroyed unlike the list elements), so this is no big deal.
BTW
hasis coming to stable FF very soon!