fix(files): disable size containment on headers #41018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Patil <[email protected]>
skjnldsv
approved these changes
Oct 20, 2023
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
AH, yes, makes more sense indeed :)
susnux
approved these changes
Oct 20, 2023
Member
|
/compile |
juliusknorr
approved these changes
Oct 20, 2023
juliusknorr
added
4. to release
Member
|
Thanks for the quick fix 💙 |
Signed-off-by: nextcloud-command <[email protected]>
susnux
approved these changes
Oct 20, 2023
Member
|
Sorry to bug again, unfortunately this still seems to cause issues with the popover menu that text might show which is cut off and no longer overlaying the content.
Any chance you could have another look at that as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by the header being variable height: see #40958 (comment)
cc @juliushaertl