Skip to content

Conversation

@pulsejet
Copy link
Member

Follow up of #40958

I got the will-change wrong previously; it's the table that's scrolling, not the tbody. The performance with this patch is absolutely insane (we might want to increase the buffer a bit from 3 though). It's so good, actually, that I'm considering making this scroller into a standalone library (unless there's already a plan for that).

Here's how the updates during scrolling look like:

Before After
wc_before wc_after

@pulsejet pulsejet requested review from skjnldsv and susnux October 19, 2023 20:00
@pulsejet pulsejet added this to the Nextcloud 28 milestone Oct 19, 2023
@pulsejet pulsejet added the 3. to review Waiting for reviews label Oct 19, 2023
@pulsejet
Copy link
Member Author

Note: I noticed this is somewhat browser dependent. Firefox seems to already have been detecting and applying this optimization. So the main difference here is for Chromium (and maybe WebKit)

@susnux
Copy link
Contributor

susnux commented Oct 19, 2023

Nice! 🚀

But please fix the missing signoff 😉

@pulsejet pulsejet force-pushed the files-list-will-change branch from 28378e7 to 5b91fb1 Compare October 19, 2023 20:12
@pulsejet
Copy link
Member Author

pulsejet commented Oct 19, 2023

But please fix the missing signoff 😉

Argh not again 😩 .. done!

we might want to increase the buffer a bit from 3 though

need opinion on this btw, if anyone can test scrolling fast in a large directory. I think 5 or 6 might be good (EDIT: or maybe it's not that important ... can't see a lot of difference)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 20, 2023
@skjnldsv
Copy link
Member

need opinion on this btw, if anyone can test scrolling fast in a large directory. I think 5 or 6 might be good (EDIT: or maybe it's not that important ... can't see a lot of difference)

All my tests and development over the last months have been done on a 1k images folder :)

@skjnldsv skjnldsv force-pushed the files-list-will-change branch from 5b91fb1 to 9ac365d Compare October 20, 2023 08:30
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv
Copy link
Member

@pulsejet your commit names doesn't follow conventional commits
files: fix virtual list will-change value should be fix(files): virtual list will-change value (adjusted)

@skjnldsv skjnldsv force-pushed the files-list-will-change branch from 9ac365d to 2db1eab Compare October 20, 2023 08:50
@skjnldsv skjnldsv merged commit e49353d into master Oct 20, 2023
@skjnldsv skjnldsv deleted the files-list-will-change branch October 20, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants