Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Aug 2, 2024

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (d8abc13) and #3577 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3577.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (2)
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm

Required conditions to stay in the queue:

---
previous_failed_batches:
  - checked_pull_requests:
      - 3497
    draft_pr_number: 3581
pull_requests:
  - number: 3577
...

@codecov
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 65.90464% with 522 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (d8abc13) to head (1da8658).

Files Patch % Lines
crates/tx_prelude/src/proof_of_stake.rs 0.00% 59 Missing ⚠️
crates/core/src/ibc.rs 0.00% 56 Missing ⚠️
crates/proof_of_stake/src/queries.rs 41.66% 49 Missing ⚠️
...s/node/src/shell/vote_extensions/val_set_update.rs 0.00% 32 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 30 Missing ⚠️
...rates/node/src/shell/vote_extensions/eth_events.rs 0.00% 26 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 23 Missing ⚠️
...ge/src/protocol/validation/validator_set_update.rs 8.33% 22 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.60% 22 Missing ⚠️
crates/trans_token/src/lib.rs 50.00% 22 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
- Coverage   54.55%   54.54%   -0.01%     
==========================================
  Files         324      323       -1     
  Lines      113435   113852     +417     
==========================================
+ Hits        61883    62103     +220     
- Misses      51552    51749     +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Aug 2, 2024
@mergify mergify bot deleted the mergify/merge-queue/fade60566f branch August 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants