Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Jul 9, 2024

Describe your changes

Dependency injection for proof_of_stake, replacing deps on:

  • governance
  • parameters
  • trans_token

To help with these changes, the pos_queries mod was refactored out in de1555a

Indicate on which release or other PRs this topic is based on

Depends-On: #3482

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic force-pushed the tomas/di-pos branch 2 times, most recently from b681df7 to 0d82229 Compare July 11, 2024 13:10
tzemanovic added a commit that referenced this pull request Jul 11, 2024
@tzemanovic tzemanovic marked this pull request as ready for review July 11, 2024 13:12
@tzemanovic tzemanovic requested a review from brentstone July 11, 2024 13:13
tzemanovic added a commit that referenced this pull request Jul 12, 2024
@tzemanovic tzemanovic mentioned this pull request Jul 12, 2024
5 tasks
@tzemanovic tzemanovic mentioned this pull request Jul 29, 2024
tzemanovic added a commit that referenced this pull request Jul 29, 2024
@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 73.55049% with 406 lines in your changes missing coverage. Please review.

Project coverage is 54.58%. Comparing base (1154023) to head (aa570a1).
Report is 29 commits behind head on main.

Files Patch % Lines
crates/tx_prelude/src/proof_of_stake.rs 0.00% 59 Missing ⚠️
crates/proof_of_stake/src/queries.rs 41.66% 49 Missing ⚠️
...s/node/src/shell/vote_extensions/val_set_update.rs 0.00% 32 Missing ⚠️
...rates/node/src/shell/vote_extensions/eth_events.rs 0.00% 26 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.58% 26 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 23 Missing ⚠️
...ge/src/protocol/validation/validator_set_update.rs 8.33% 22 Missing ⚠️
...ridge/src/protocol/validation/bridge_pool_roots.rs 14.28% 18 Missing ⚠️
crates/token/src/lib.rs 25.00% 18 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 15 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   54.51%   54.58%   +0.06%     
==========================================
  Files         323      323              
  Lines      113288   113736     +448     
==========================================
+ Hits        61762    62083     +321     
- Misses      51526    51653     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request


/// Initialize or set the value at the given epoch offset.
pub fn set<S>(
pub fn set<S, Gov>(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes in epoched were the annoying ones as they end up bubbling up through a lot of fns that use these (we depend on a gov parameter for the OffsetMaxProposalPeriod epoch offset)

@tzemanovic
Copy link
Collaborator Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024

refresh

✅ Pull request refreshed

@tzemanovic tzemanovic requested a review from Fraccaman July 31, 2024 14:13
@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 2, 2024
@mergify mergify bot merged commit aa570a1 into main Aug 2, 2024
@mergify mergify bot deleted the tomas/di-pos branch August 2, 2024 10:40
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants