-
Notifications
You must be signed in to change notification settings - Fork 1k
DI - PoS #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI - PoS #3497
Conversation
b681df7 to
0d82229
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3497 +/- ##
==========================================
+ Coverage 54.51% 54.58% +0.06%
==========================================
Files 323 323
Lines 113288 113736 +448
==========================================
+ Hits 61762 62083 +321
- Misses 51526 51653 +127 ☔ View full report in Codecov by Sentry. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
|
|
||
| /// Initialize or set the value at the given epoch offset. | ||
| pub fn set<S>( | ||
| pub fn set<S, Gov>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes in epoched were the annoying ones as they end up bubbling up through a lot of fns that use these (we depend on a gov parameter for the OffsetMaxProposalPeriod epoch offset)
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
Describe your changes
Dependency injection for proof_of_stake, replacing deps on:
To help with these changes, the
pos_queriesmod was refactored out in de1555aIndicate on which release or other PRs this topic is based on
Depends-On: #3482
Checklist before merging to
draft