Skip to content

Conversation

@tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Aug 1, 2024

Describe your changes

closes #3467

Indicate on which release or other PRs this topic is based on

#3509

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic
Copy link
Collaborator Author

unfortunately the bound S: StateRead is still needed for native VP Ctx as the inner PrefixIterators needs it to get its <S as StateRead>::DBIter::PrefixIter which propagates up to all the native VPs

@tzemanovic tzemanovic marked this pull request as ready for review August 1, 2024 10:59
@tzemanovic tzemanovic requested a review from sug0 August 1, 2024 10:59
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 1, 2024
mergify bot added a commit that referenced this pull request Aug 1, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@codecov
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 65.90464% with 522 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (1fbb9fd) to head (1ff2f61).
Report is 19 commits behind head on main.

Files Patch % Lines
crates/tx_prelude/src/proof_of_stake.rs 0.00% 59 Missing ⚠️
crates/core/src/ibc.rs 0.00% 56 Missing ⚠️
crates/proof_of_stake/src/queries.rs 41.66% 49 Missing ⚠️
...s/node/src/shell/vote_extensions/val_set_update.rs 0.00% 32 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 30 Missing ⚠️
...rates/node/src/shell/vote_extensions/eth_events.rs 0.00% 26 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 23 Missing ⚠️
...ge/src/protocol/validation/validator_set_update.rs 8.33% 22 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.60% 22 Missing ⚠️
crates/trans_token/src/lib.rs 50.00% 22 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
- Coverage   54.54%   54.54%   -0.01%     
==========================================
  Files         324      323       -1     
  Lines      113438   113855     +417     
==========================================
+ Hits        61880    62100     +220     
- Misses      51558    51755     +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman
Copy link
Collaborator

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 2, 2024
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

Hey @tzemanovic, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@Fraccaman
Copy link
Collaborator

@mergify requeue

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 2, 2024
mergify bot added a commit that referenced this pull request Aug 2, 2024
@mergify mergify bot merged commit fdf8471 into main Aug 2, 2024
@mergify mergify bot deleted the tomas/relax-bounds branch August 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove trait bounds from struct definitions where possible

4 participants