Fix unit error in CCCVcharging #4112
Conversation
henrikt-ma
added
the
L: Electrical.Batteries
AHaumer
left a comment
AHaumer
left a comment
There was a problem hiding this comment.
I'd suggest the following change:
parameter Modelica.Units.SI.Current Isc = 1200 "Short-circuit current of cell at OCVmax";
Why don't make this parameter public?
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
|
Coordinate as described in #4101 |
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
@henrikt-ma I suggest to remove public, see suggestion.
Other than that, I am in favor of approving this proposal.
in other Batteries.Examples
christiankral
left a comment
christiankral
left a comment
There was a problem hiding this comment.
OCVmax and Isc are now considered in each battery example
Co-authored-by: Hans Olsson <[email protected]>
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Fine by me - I think it is better to wait for actual expert approval; and I haven't figured out how to remove myself as reviewer.
hubertus65
left a comment
hubertus65
left a comment
There was a problem hiding this comment.
Looks good, and approved in MAP-LIB meeting
hubertus65
dismissed
AHaumer’s stale review
This is outdated and fixed as suggested.
7 participants
No description provided.