Skip to content

Fix unit error in CCCVcharging #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Fix unit error in CCCVcharging #4112

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
183fe6d
Fix unit error in CCCVcharging
henrikt-ma Apr 6, 2023
1f85689
Rename RiCurrent -> Isc
henrikt-ma May 25, 2023
1f422fc
Adapt to renamed variable
henrikt-ma May 25, 2023
1969bc1
Make it public, as suggested
henrikt-ma May 25, 2023
eef1cb0
Remove public
christiankral Oct 18, 2023
739babf
Coordination of #4101: Fix unit errors
christiankral Oct 18, 2023
82208e4
Fix instance names
christiankral Oct 18, 2023
8450a8e
Close #4101: Fix unit error in a single PR
christiankral Oct 18, 2023
bcf0b77
Remove blanks
christiankral Oct 18, 2023
abb35f2
Fix factor 2 in calculation
christiankral Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Modelica/Electrical/Batteries/Examples/CCCVcharging.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ within Modelica.Electrical.Batteries.Examples;
model CCCVcharging
"Charge a battery with constant current - constant voltage characteristic"
extends Modelica.Icons.Example;
parameter Modelica.Units.SI.Current Isc = 1200 "Short-circuit current of cell at OCVmax";
public
parameter Modelica.Electrical.Batteries.ParameterRecords.TransientData.ExampleData cellData(
Qnom=18000,
useLinearSOCDependency=false,
Ri=cellData.OCVmax/1200,
Ri=cellData.OCVmax/Isc,
Idis=0.001)
annotation (Placement(transformation(extent={{20,-20},{40,0}})));
Modelica.Electrical.Batteries.BatteryStacks.CellRCStack battery(
Expand Down