Fix unit error in BatteryDischargeCharge

[qlambert-pro]

The magic number 1200, should be carying a unit in order for unit checking to pass. I wasn't inspired, when it came to naming the constant, so feel free to suggest a better name.

[HansOlsson]

Looking at the code it's as if it is the short-circuit current of the battery, which explains the dangerously high number.

[AHaumer]

See #4412 #4112:
parameter Modelica.Units.SI.Current Isc = 1200 "Short-circuit current of cell at OCVmax";
Instead of having a lot of single PR's, why don't look through these examples systematically and provide the same for CCCV_Cell, CCCV_CellRC, CCCV_Stack, CCCV_StackRC.

[HansOlsson]

See #4412: parameter Modelica.Units.SI.Current Isc = 1200 "Short-circuit current of cell at OCVmax"; Instead of having a lot of single PR's, why don't look through these examples systematically and provide the same for CCCV_Cell, CCCV_CellRC, CCCV_Stack, CCCV_StackRC.

You mean #4112 - and I agree that having one common PR for them makes more sense.

[HansOlsson]

Coordinate/merge with #4112

[HansOlsson]

Coordinate/merge with #4112

Specifically:

• All of the similar classes in one PR
• Same name (Isc) and description "Short circuit current"
• Same variability (parameter)

[christiankral]

This issue is fixed in 8450a8e by #4112

[christiankral]

This issue is fixed in 8450a8e by #4112

Therefore, this ticket can be closed.