Skip to content

Conversation

@bpasero
Copy link
Member

@bpasero bpasero commented Oct 31, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the todo list widget to show a spinning loading icon for in-progress tasks and improves the "Done" message to display the task count consistently with other states.

Key changes:

  • Modified the getStatusIconClass method to return an array of CSS classes instead of a single class, enabling support for multiple classes like the spinning animation modifier
  • Updated the "Done" message to include the total count format for consistency

@bhavyaus
Copy link
Collaborator

bhavyaus commented Oct 31, 2025

This removes the icons from the header -> was this intentional?
image

Also, the spinner continues to animate after the response is completed or stopped, when there are in-progress todos.
image
That feels off to me.

We should consider showing a canceleld icon or reset its state to not-started in the widget to avoid showing a spinner when nothing is happening

@bpasero
Copy link
Member Author

bpasero commented Nov 1, 2025

@bhavyaus

This removes the icons from the header -> was this intentional?

this was only done so that todos - when collapsed - look similar to the edit working set below since that one also does not have an icon. We could play with having the icon to the right though.

Also, the spinner continues to animate after the response is completed or stopped, when there are in-progress todos.

That is a good point, but that was already the case before, with the previous in-progress icon, even though not animated. Do we know when the response stopped and could track that as another state in the todo widget?

@bpasero
Copy link
Member Author

bpasero commented Nov 1, 2025

Also not very pretty:
image

This is not ready, closing for now.

@bpasero bpasero closed this Nov 1, 2025
auto-merge was automatically disabled November 1, 2025 08:42

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants