Chat: do not render UI things in schedulers at random intervals

[bpasero]

vscode/src/vs/workbench/contrib/chat/browser/chatWidget.ts

Line 551 in afd4a5e

this._welcomeRenderScheduler = this._register(new RunOnceScheduler(() => this.renderWelcomeViewContentIfNeeded(), 10));

vscode/src/vs/workbench/contrib/chat/browser/chatWidget.ts

Lines 558 to 560 in afd4a5e

	this._chatSuggestNextScheduler = this._register(
	new RunOnceScheduler(() => this.renderChatSuggestNextWidget(), 20),
	);

This pattern of scheduling UI code on random timeouts has to stop. It seems to be a "fix"/"workaround" to prevent re-entrant calls from happening but that cannot be the solution.

//cc @aeschli @digitarald

[bhavyaus]

Not sure why the suggest widget is on a scheduler. Removing with: #274276

I'd like to leave the welcome view rendering as is. We call in to render the welcome view a ton on startup and
I added that to address: #262472 (comment)
Let me know if you think otherwise.

cc: @justschen

[bpasero]

@bhavyaus but why is that a scheduler with a timeout? If you want to prevent the method calling itself why don't you simply have a boolean that tracks if the method is currently executing? You don't need a scheduler for that do you? The renderWelcomeViewContentIfNeeded is not even async 🤔

[bhavyaus]

Not sure why we set it with a non-zero time out. Will investigate and clean up durng debt week. For now keeping fix minimal with #275915