Skip to content

Chat todos: revisit icons used for tasks and in progress (fix #273083) #274276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Chat todos: revisit icons used for tasks and in progress (fix #273083) #274276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d72637
Chat todos: revisit icons used for tasks and in progress (fix #273083)
bpasero Oct 31, 2025
463c1bc
Merge branch 'main' into ben/premier-raven
bpasero Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions src/vs/workbench/contrib/chat/browser/chatContentParts/chatTodoListWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class TodoListRenderer implements IListRenderer<IChatTodo, ITodoListTemplate> {
const { todoElement, statusIcon, iconLabel } = templateData;

// Update status icon
statusIcon.className = `todo-status-icon codicon ${this.getStatusIconClass(todo.status)}`;
statusIcon.className = `todo-status-icon codicon ${this.getStatusIconClass(todo.status).join(' ')}`;
statusIcon.style.color = this.getStatusIconColor(todo.status);

// Update title with tooltip if description exists and description field is enabled
Expand Down Expand Up @@ -96,15 +96,15 @@ class TodoListRenderer implements IListRenderer<IChatTodo, ITodoListTemplate> {
}
}

private getStatusIconClass(status: string): string {
private getStatusIconClass(status: string): string[] {
switch (status) {
case 'completed':
return 'codicon-pass';
return ['codicon-pass'];
case 'in-progress':
return 'codicon-record';
return ['codicon-loading', 'codicon-modifier-spin'];
case 'not-started':
default:
return 'codicon-circle-outline';
return ['codicon-circle-outline'];
}
}

Expand Down Expand Up @@ -401,18 +401,6 @@ export class ChatTodoListWidget extends Disposable {
// Show first in-progress todo, or if none, the first not-started todo
const todoToShow = firstInProgressTodo || firstNotStartedTodo;
if (todoToShow) {
const icon = dom.$('.codicon');
if (todoToShow === firstInProgressTodo) {
icon.classList.add('codicon-record');
icon.style.color = 'var(--vscode-charts-blue)';
} else {
icon.classList.add('codicon-circle-outline');
icon.style.color = 'var(--vscode-foreground)';
}
icon.style.marginRight = '4px';
icon.style.verticalAlign = 'middle';
titleElement.appendChild(icon);

const todoText = dom.$('span');
todoText.textContent = localize('chat.todoList.currentTask', '{0} ({1}/{2})', todoToShow.title, currentTaskNumber, totalCount);
todoText.style.verticalAlign = 'middle';
Expand All @@ -425,7 +413,7 @@ export class ChatTodoListWidget extends Disposable {
// Show "Done" when all tasks are completed
else if (completedCount > 0 && completedCount === totalCount) {
const doneText = dom.$('span');
doneText.textContent = localize('chat.todoList.allDone', 'Done');
doneText.textContent = localize('chat.todoList.allDone', 'Done ({0}/{0})', totalCount);
doneText.style.verticalAlign = 'middle';
titleElement.appendChild(doneText);
}
Expand Down
Loading