Skip to content

Conversation

@OnkarRuikar
Copy link
Contributor

Adding to #18170.

@OnkarRuikar OnkarRuikar requested a review from a team July 10, 2022 06:54
@OnkarRuikar OnkarRuikar requested review from a team as code owners July 10, 2022 06:54
@OnkarRuikar OnkarRuikar requested review from Josh-Cena, Rumyra, estelle, jpmedley and schalkneethling and removed request for a team July 10, 2022 06:54
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:Media Media docs Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebAPI Web API docs labels Jul 10, 2022
@github-actions

This comment was marked as resolved.

@OnkarRuikar
Copy link
Contributor Author

@teoli2003, @Josh-Cena regarding moving to prettier.

There are some cases in code like:

function foo() {
    const a = 1;
    ...
}

Should we convert them to

function foo() {
    const a = 1;
    // ...
}

so it'll not choke the eslint/prettier?

@Josh-Cena
Copy link
Member

Absolutely 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn Learning area docs Content:MathML MathML docs Content:Media Media docs Content:SVG SVG docs Content:wasm WebAssembly docs Content:WebAPI Web API docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants