-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Comment out ellipsis in code blocks #18430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
teoli2003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits and we can merge this.
files/en-us/web/api/ext_disjoint_timer_query/getqueryobjectext/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/file_api/using_files_from_web_applications/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Perrier <[email protected]>
|
Some pages on mdn/content have placeholder sections like: Should we remove them? |
Yes, please. That way, when we start enforcing the presence of the mandatory sections, they will be listed as missing the examples. Also, it gives false expectations to the reader that believes there is an example and is disappointed when it reaches the section. This is a remnant of the Wiki era where authors edited the new pages directly in the live MDN, then forget about it (because some manager told them to move to something more urgent) |
teoli2003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ellipsis in markdown code blocks are syntax errors.
In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses. Refer the discussion for more context.