-
Notifications
You must be signed in to change notification settings - Fork 23.1k
Comment out ellipsis in code blocks #18567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
8a23326 to
97d0ea0
Compare
files/en-us/web/javascript/reference/functions/arrow_functions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/functions/arrow_functions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/@@iterator/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/array/@@iterator/index.md
Outdated
Show resolved
Hide resolved
|
@teoli2003 @OnkarRuikar Sorry I was not closely following this process before. I have a question about semantics. The goal of this update is to make code blocks syntactically valid. However some changes don't really make the code any more or less valid. For example: // Both invalid
- const a = ...;
+ const a = /* … */;
// Both valid
- console.log(foo); // { … }
+ console.log(foo); // { /* … */ }Instead, I think it actually makes the point less clear. What about using |
|
(Also, I'm skeptical about replacing |
Co-authored-by: Jean-Yves Perrier <[email protected]>
…/index.md Co-authored-by: Jean-Yves Perrier <[email protected]>
Are we going to lint inline code(e.g. `const a = 9` as well?
- console.log(foo); // { … }
+ console.log(foo); // { /* … */ }I got these as review suggestions. You guys decide and, if needed, I'll correct it in all the pages. |
|
No—we don't lint inline code. It was more of a general question. |
Ellipsis in markdown code blocks are syntax errors.
In order to have smooth transition to Prettier and ESLint the PR comments out such bare ellipses. Refer the #18171 (comment) for more context.