Merged
Conversation
This was referenced Sep 22, 2022
4 tasks
Contributor
|
We should definitely merge #2960 before we release the next version. |
Contributor
|
Same with #2974. |
Member
Author
|
If I am not mistaken, all blockers for this release have been resolved. (In general, I don't think it makes sense to block a release on a feature. I much rather cut a new release for that feature once merged.) @thomaseizinger @elenaf9 @jxs am I missing anything? Mind giving this a review? |
thomaseizinger
approved these changes
Oct 13, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
LGTM!
I am gonna trigger another update so we can see the checks introduced with #2647.
elenaf9
approved these changes
Oct 13, 2022
4 tasks
4 tasks
Member
Author
|
Tagged and published the following crates:
|
4 tasks
thomaseizinger
pushed a commit
to kpp/rust-libp2p
that referenced
this pull request
Oct 17, 2022
4 tasks
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for the
libp2pv0.49.0release.Waiting on:
NetworkBehaviourby full path #2932Links to any relevant issues
Open Questions
Anything else folks would like to block this release on?
Change checklist