swarm: Provide peer_id to inject_dial_failure on connection limit error#2928
Merged
mxinden merged 4 commits intolibp2p:masterfrom Sep 23, 2022
Merged
swarm: Provide peer_id to inject_dial_failure on connection limit error#2928mxinden merged 4 commits intolibp2p:masterfrom
mxinden merged 4 commits intolibp2p:masterfrom
Conversation
mxinden
reviewed
Sep 22, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thank you @dariusc93. Can you also bump the libp2p-swarm version in the root Cargo.toml and reference the version bump in the root Changelog.md?
dariusc93
force-pushed
the
libp2p-dial-failure-fix
branch
from
91af29b to
965c02c
Compare
Member
Author
Went on and updated the root |
thomaseizinger
approved these changes
Sep 23, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks! Just one comment, otherwise LGTM!
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Member
|
Interoperability tests failing due to libp2p/test-plans#41. Merging here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will fix the panic by providing the
peer_idtoinject_dial_failureLinks to any relevant issues
#2906
Open Questions
Change checklist