Skip to content

swarm-derive: Specify NetworkBehaviour by full path#2932

Merged
thomaseizinger merged 5 commits intolibp2p:masterfrom
fluencelabs:net_behaviour_derive_fix
Sep 27, 2022
Merged

swarm-derive: Specify NetworkBehaviour by full path#2932
thomaseizinger merged 5 commits intolibp2p:masterfrom
fluencelabs:net_behaviour_derive_fix

Conversation

@folex
Copy link
Copy Markdown
Contributor

@folex folex commented Sep 22, 2022

Description

Specify NetworkBehaviour as ::libp2p::swarm::NetworkBehaviour in derive.

Links to any relevant issues

#2921

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
Copy link
Copy Markdown
Member

mxinden commented Sep 22, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing the patch. I will make sure it makes it into v0.49.0 (#2931).

@mxinden mxinden mentioned this pull request Sep 22, 2022
4 tasks
Copy link
Copy Markdown
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this patch.

LGTM modulo the changelog and @mxinden's suggestion!

Co-authored-by: Thomas Eizinger <[email protected]>
@folex
Copy link
Copy Markdown
Contributor Author

folex commented Sep 26, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

@thomaseizinger
Copy link
Copy Markdown
Contributor

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

@thomaseizinger thomaseizinger changed the title swarm-derive: specify NetworkBehaviour by full path swarm-derive: Specify NetworkBehaviour by full path Sep 27, 2022
@thomaseizinger thomaseizinger changed the title swarm-derive: Specify NetworkBehaviour by full path swarm-derive: Specify NetworkBehaviour by full path Sep 27, 2022
@folex
Copy link
Copy Markdown
Contributor Author

folex commented Sep 27, 2022

@folex can you grant me permissions to merge master into your branch? I have a bunch of pull requests lined up, thus having me do it will safe a bit of time on both ends.

I don't see how to do that in GitHub without actually adding you to the fluencelabs org -_-

There is a checkbox next to the people that are subscribed to the PR that will allow us to push to this branch only.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Seems like that doesn't work with organisations, only with personal forks. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants