fix(l1): sleep between FCU and getPayload calls in dev-mode block producer #5310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to fix a timing issue in dev-mode block production by moving the sleep interval from after block production to between the FCU (forkchoiceUpdated) and getPayload calls. The change switches from tokio::time::sleep to tokio::time::interval for more precise timing control.
Key Changes:
- Added
Durationimport and created atokio::time::intervalticker - Moved the timing delay from the end of the loop to between FCU and getPayload calls
- Removed the
tokio::time::sleepat the end of the loop
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Nov 13, 2025
SDartayet
approved these changes
Nov 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
**Description** This commit reverts the revert of #5205 done in #5257. As of #5310, the dev mode block producer now waits for the configured amount of time after initiating the payload build process and before retrieving the built payload, rather than after payload validation. This solves the issue we were having after merging #5205 where empty payloads were retrieved because the `engine_getPayload` call was immediately done after the `engine_forkChoiceUpdate`.
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
…ducer (lambdaclass#5310) **Motivation** Our `--dev` block production had a bug where we waited an interval before sending an FCU and called getPayload immediately after, causing inclusion latency to be 1.5x the interval. **Description** This PR moves the sleep between the FCU and getPayload calls, fixing the issue. It also switches to `tokio::time::interval` for more precision.
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
**Description** This commit reverts the revert of lambdaclass#5205 done in lambdaclass#5257. As of lambdaclass#5310, the dev mode block producer now waits for the configured amount of time after initiating the payload build process and before retrieving the built payload, rather than after payload validation. This solves the issue we were having after merging lambdaclass#5205 where empty payloads were retrieved because the `engine_getPayload` call was immediately done after the `engine_forkChoiceUpdate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our
--devblock production had a bug where we waited an interval before sending an FCU and called getPayload immediately after, causing inclusion latency to be 1.5x the interval.Description
This PR moves the sleep between the FCU and getPayload calls, fixing the issue. It also switches to
tokio::time::intervalfor more precision.