Skip to content

fix(l1): sleep between FCU and getPayload calls in dev-mode block producer #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SDartayet merged 3 commits into from
Nov 13, 2025
Merged

fix(l1): sleep between FCU and getPayload calls in dev-mode block producer #5310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18f9cbb
fix(l1): wait for block to be built before calling getPayload
MegaRedHand Nov 12, 2025
7b3961a
fix: add an initial sleep to avoid timestamp collision
MegaRedHand Nov 12, 2025
c198a0e
chore: add comment
MegaRedHand Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions crates/blockchain/dev/block_producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use ethereum_types::{Address, H256};
use ethrex_rpc::clients::{EngineClient, EngineClientError};
use ethrex_rpc::types::fork_choice::{ForkChoiceState, PayloadAttributesV3};
use sha2::{Digest, Sha256};
use std::time::{SystemTime, UNIX_EPOCH};
use std::time::{Duration, SystemTime, UNIX_EPOCH};

pub async fn start_block_producer(
execution_client_auth_url: String,
Expand All @@ -15,6 +15,11 @@ pub async fn start_block_producer(
) -> Result<(), EngineClientError> {
let engine_client = EngineClient::new(&execution_client_auth_url, jwt_secret);

let mut ticker = tokio::time::interval(Duration::from_millis(block_production_interval_ms));

// Sleep until the first tick to avoid timestamp collision with the genesis block.
ticker.tick().await;

let mut head_block_hash: H256 = head_block_hash;
let parent_beacon_block_root = H256::zero();
let mut tries = 0;
Expand Down Expand Up @@ -53,6 +58,11 @@ pub async fn start_block_producer(
let payload_id = fork_choice_response
.payload_id
.expect("Failed to produce block: payload_id is None in ForkChoiceResponse");

// Wait for the next tick to retrieve the payload.
// Note that this makes getPayload failures result in skipped blocks.
ticker.tick().await;

let execution_payload_response = match engine_client.engine_get_payload_v5(payload_id).await
{
Ok(response) => {
Expand Down Expand Up @@ -113,11 +123,6 @@ pub async fn start_block_producer(
tracing::info!("Produced block {produced_block_hash:#x}");

head_block_hash = produced_block_hash;

tokio::time::sleep(tokio::time::Duration::from_millis(
block_production_interval_ms,
))
.await;
}
Err(EngineClientError::SystemFailed(format!("{max_tries}")))
}