fix(l1): build initial empty block in block building #5205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
cdiielsi
approved these changes
Nov 10, 2025
crates/blockchain/payload.rs
Outdated
| let start = Instant::now(); | ||
| const SECONDS_PER_SLOT: Duration = Duration::from_secs(12); | ||
| // Attempt to rebuild the payload as many times within the given timeframe to maximize fee revenue | ||
| // TODO(#4997): start with an empty block |
Contributor
There was a problem hiding this comment.
Shouldn't this TODO be dropped now?
MegaRedHand
approved these changes
Nov 10, 2025
MegaRedHand
approved these changes
Nov 10, 2025
ilitteri
pushed a commit
that referenced
this pull request
Nov 10, 2025
This reverts commit 45a9871.
SDartayet
added a commit
that referenced
this pull request
Nov 10, 2025
This reverts commit 45a9871.
This was referenced Nov 10, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
xqft
pushed a commit
that referenced
this pull request
Nov 11, 2025
SDartayet
added a commit
that referenced
this pull request
Nov 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
**Description** This commit reverts the revert of #5205 done in #5257. As of #5310, the dev mode block producer now waits for the configured amount of time after initiating the payload build process and before retrieving the built payload, rather than after payload validation. This solves the issue we were having after merging #5205 where empty payloads were retrieved because the `engine_getPayload` call was immediately done after the `engine_forkChoiceUpdate`.
lakshya-sky
pushed a commit
to lakshya-sky/ethrex
that referenced
this pull request
Nov 17, 2025
**Description** This commit reverts the revert of lambdaclass#5205 done in lambdaclass#5257. As of lambdaclass#5310, the dev mode block producer now waits for the configured amount of time after initiating the payload build process and before retrieving the built payload, rather than after payload validation. This solves the issue we were having after merging lambdaclass#5205 where empty payloads were retrieved because the `engine_getPayload` call was immediately done after the `engine_forkChoiceUpdate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Properly complying with the block building spec.
Description
As outlined in #4997, we should be bulding an initial empty block before filling it with transactions. This PR fixes that.
Closes #4997