Skip to content

Add verification scripts for service-apis #15699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 10, 2020
Merged

Add verification scripts for service-apis #15699

k8s-ci-robot merged 1 commit into from
Jan 10, 2020

Conversation

@aledbf
Copy link
Member

@aledbf aledbf commented Dec 29, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 29, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

This requires xref: kubernetes-sigs/gateway-api#7

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 29, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2020
@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2020
@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

/assign @bowei

@chases2
Copy link
Contributor

chases2 commented Jan 6, 2020

/lgtm
Leaving it to the OWNERS to approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@aojea
Copy link
Member

aojea commented Jan 8, 2020

/lgtm
I've tested it and works

aojeagarcia   master  …  src  sigs.k8s.io  service-apis  hack/verify-all.sh 
Running in the silent mode, run with -v if you want to see script logs.
Skipping hack/../hack/verify-all.sh
Verifying hack/../hack/verify-boilerplate.sh
SUCCESS
Verifying hack/../hack/verify-gofmt.sh
SUCCESS
Verifying hack/../hack/verify-golint.sh
SUCCESS

@bowei needs your approval :)

@aledbf aledbf mentioned this pull request Jan 8, 2020
Closed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 8, 2020

@howardjohn: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf mentioned this pull request Jan 9, 2020
Merged
@aledbf
28fd9d5 
Add verification scripts for service-apis
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@bowei
Copy link
Member

bowei commented Jan 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@bowei
Copy link
Member

bowei commented Jan 10, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 769ec80 into kubernetes:master Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 10, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2020

@aledbf: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key service-apis-config.yaml using file config/jobs/kubernetes-sigs/service-apis/service-apis-config.yaml
Details

In response to this:

Configuration for https://github.com/kubernetes-sigs/service-apis

xref: kubernetes-sigs/gateway-api#2
xref: kubernetes-sigs/gateway-api#7
xref: kubernetes-sigs/gateway-api#24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf deleted the svc-apis branch January 10, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@chases2 chases2 Awaiting requested review from chases2

1 more reviewer

@howardjohn howardjohn howardjohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bowei bowei

@chases2 chases2

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.18

Development

Successfully merging this pull request may close these issues.

6 participants

@aledbf @chases2 @aojea @k8s-ci-robot @bowei @howardjohn