Skip to content

Conversation

@aojea
Copy link
Member

@aojea aojea commented Jan 9, 2020

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2020
@aojea
Copy link
Member Author

aojea commented Jan 9, 2020

/assign @bowei

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2020
@BenTheElder
Copy link
Member

cc @aledbf - IIRC you were also working with this right?

@aledbf
Copy link
Member

aledbf commented Jan 9, 2020

@BenTheElder no, I was working in this #15699

# this is the github repo we'll build from; this block needs to be repeated for each repo.
kubernetes-sigs/k8s-container-image-promoter:
- name: service-apis-postsubmit-push-to-staging
cluster: test-infra-trusted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jobs that run in the trusted cluster need to be defined in the trusted file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed the instructions from https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md

How do I add the job to the "trusted" file 😅 ?

Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this directory will suffice

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit d6212fa into kubernetes:master Jan 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 13, 2020
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-service-apis.yaml using file config/jobs/image-pushing/k8s-staging-service-apis.yaml
Details

In response to this:

xref kubernetes-sigs/gateway-api#3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants