-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add service-apis image pushing job #15828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @bowei |
|
cc @aledbf - IIRC you were also working with this right? |
|
@BenTheElder no, I was working in this #15699 |
| # this is the github repo we'll build from; this block needs to be repeated for each repo. | ||
| kubernetes-sigs/k8s-container-image-promoter: | ||
| - name: service-apis-postsubmit-push-to-staging | ||
| cluster: test-infra-trusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jobs that run in the trusted cluster need to be defined in the trusted file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed the instructions from https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
How do I add the job to the "trusted" file 😅 ?
fejta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this directory will suffice
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aojea: Updated the
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xref kubernetes-sigs/gateway-api#3