Skip to content

Update go dependencies to v1.17.0 and go to 1.13.5 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 5 commits into from
Jan 3, 2020
Merged

Update go dependencies to v1.17.0 and go to 1.13.5 #7

k8s-ci-robot merged 5 commits into from
Jan 3, 2020

Conversation

@aledbf
Copy link
Member

@aledbf aledbf commented Dec 29, 2019 •
edited
Loading

replaces #5
fixes #2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2019

Welcome @aledbf!

It looks like this is your first PR to kubernetes-sigs/service-apis 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/service-apis has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2019

Hi @aledbf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2019
@aledbf aledbf mentioned this pull request Dec 29, 2019
Merged
@aojea aojea mentioned this pull request Jan 1, 2020
Closed
@aojea
Copy link
Contributor

aojea commented Jan 1, 2020

/test pull-service-apis-build
/assign @bowei

@aojea
Copy link
Contributor

aojea commented Jan 1, 2020

fails because the jobs needs docker :/

make[1]: Entering directory '/home/prow/go/src/sigs.k8s.io/service-apis'
docker build -t k8s.gcr.io/service-apis-mkdocs:latest -f mkdocs.dockerfile .
make[1]: docker: Command not found

@aojea aojea mentioned this pull request Jan 1, 2020
Merged
@bowei
Copy link
Contributor

bowei commented Jan 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2020
@bowei
Copy link
Contributor

bowei commented Jan 2, 2020

Approved the prow setup -- let's see if it works

@aledbf
Copy link
Member Author

aledbf commented Jan 2, 2020

/retest

@aojea
Copy link
Contributor

aojea commented Jan 2, 2020

didn't merge yet 😅 , I've realized that we need a pod image with docker inside
kubernetes/test-infra#15719

@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

It seems the prow job still uses the golang image https://prow.k8s.io/prowjob?prowjob=925e241b-2e5e-11ea-821b-5ef7b2587806

@aojea
Copy link
Contributor

aojea commented Jan 3, 2020

/retest

@aojea
Copy link
Contributor

aojea commented Jan 3, 2020

/test pull-service-apis-build

The PR in test-infra merged, don't know if it takes time to update prow or if I did something wrong 🤷‍♂

@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

@aojea there is some issue reloading the prow job https://kubernetes.slack.com/archives/C7J9RP96G/p1578080421043700?thread_ts=1578076927.026700&cid=C7J9RP96G

@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

/retest

@aledbf
f59e11b 
Enable go modules
@aledbf
Copy link
Member Author

aledbf commented Jan 3, 2020

@bowei the new job is working and the PR is passing now.

@bowei
Copy link
Contributor

bowei commented Jan 3, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, bowei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 984453b into kubernetes-sigs:master Jan 3, 2020
@aledbf aledbf deleted the update-deps branch January 10, 2020 23:59
jaison-tiu pushed a commit to jaison-tiu/gateway-api that referenced this pull request Apr 14, 2022
@mark-church
Merge pull request kubernetes-sigs#7 from GoogleCloudPlatform/gke-gat…
158575f 
…eway-controller

gateway examples on gke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add basic hack/ verification scripts

4 participants

@aledbf @k8s-ci-robot @aojea @bowei