Skip to content

Conversation

@sda399
Copy link
Contributor

@sda399 sda399 commented Sep 7, 2025

Hi
Following this merged PR kubernetes-sigs/kustomize#5863

I pushed this small proposal to amend Replacements doc with the following elements.

missing features:

  • label selector
  • annotation selector
  • sourceValue

new features:

  • regex support, not released yet

changes:

  • table formatting, fixed check mark
  • schema
  • explain sourceValue
  • explain label/annotation selectors
  • mention regex support
  • update the example

/cc @koba1t

references:
kubernetes-sigs/kustomize#5630
kubernetes-sigs/kustomize#5863

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sda399!

It looks like this is your first PR to kubernetes-sigs/cli-experimental 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-experimental has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2025
@sda399
Copy link
Contributor Author

sda399 commented Sep 11, 2025

Hi @seans3
if you have any spare time reading this PR. Open for suggestion 💯

@sda399
Copy link
Contributor Author

sda399 commented Sep 28, 2025

@koba1t
hi, we seem all busy professionals :)
would you mind reviewing?

@koba1t
Copy link
Member

koba1t commented Sep 28, 2025

I think this change is almost good.
Thanks @sda399!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, sda399

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 07f6f90 into kubernetes-sigs:master Sep 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants