Add regex support for Replacement selectors #5863

sda399 · 2025-02-16T13:54:49Z

re-implement replacement target selector with regex support, in the patch selector spirit
isolate select and reject functions to a new specialized struct
related issue Replacement with regex support for selectors #5862

resolves: #5862

linux-foundation-easycla · 2025-02-16T13:54:54Z

The committers listed above are authorized under a signed CLA.

✅ login: sda399 / name: zepard (f1af7ad, 2a6481b, 8f75c39, dc0344b)

k8s-ci-robot · 2025-02-16T13:54:58Z

Welcome @sda399!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-02-16T13:54:59Z

Hi @sda399. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-04-04T19:24:07Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-04-04T19:24:07Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sda399 · 2025-04-04T21:27:20Z

/label tide/merge-method-squash

koba1t · 2025-04-30T14:35:02Z

/ok-to-test

sda399 · 2025-05-28T07:40:56Z

Added some examples for regex usage in krusty

edit: @koba1t @stormqueen1990 @ncapps open for discussion, any insight or feedback would be welcome, on feature or the implementation itself.
I can be available on other channel of communication, just let me know. 👍 :):

sda399 · 2025-07-06T14:29:53Z

I've made a KRM function out of this PR. maybe it'll help trying it on existing code base for regression tests.

https://github.com/sda399/kustomize-functions/tree/main/functions/replacement-extra

koba1t · 2025-08-12T18:04:42Z

Hi @sda399
So sorry to delay review.
Based on my local testing, it doesn't appear to have regression issues, so I believe it's fine.

/lgtm
/approve

Please prepare a PR to update the documentation!
https://github.com/kubernetes-sigs/cli-experimental

k8s-ci-robot · 2025-08-12T18:04:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, sda399

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.7.1` -> `v5.8.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.8.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.8.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.7.1...kustomize/v5.8.0) ### Highlights ##### implements to replacements value in the structured data Now, We can edit yaml/json in yaml manifests with replacements transformer. See [#5679](kubernetes-sigs/kustomize#5679) ##### For example ```yaml ## source apiVersion: v1 kind: ConfigMap metadata: name: source-configmap data: HOSTNAME: www.example.com --- apiVersion: v1 kind: ConfigMap metadata: name: target-configmap data: config.json: |- {"config": { "id": "42", "hostname": "REPLACE_TARGET_HOSTNAME" }} ``` ```yaml ## replacement replacements: - source: kind: ConfigMap name: source-configmap fieldPath: data.HOSTNAME targets: - select: kind: ConfigMap name: target-configmap fieldPaths: - data.config\.json.config.hostname ``` ##### fix: Propagate Namespace correctly to Helm The long-standing bug where kustomize's namespace transformer did not pass namespaces to helmCharts has been fixed. See [#5940](kubernetes-sigs/kustomize#5940) ##### For example ```yaml ## define namespace namespace: any-namespace helmCharts: - name: minecraft repo: https://kubernetes-charts.storage.googleapis.com version: v1.2.0 # namespace: any-namespace ## propagates without additional namespace specific valuesFile: values.yaml ``` #### Feature [#5679](kubernetes-sigs/kustomize#5679): implements to replacements value in the structured data [#5863](kubernetes-sigs/kustomize#5863): Add regex support for Replacement selectors [#5930](kubernetes-sigs/kustomize#5930): feat: add PatchArgs API type to populate patch options #### fix [#5940](kubernetes-sigs/kustomize#5940): fix: Propagate Namespace correctly to Helm [#5971](kubernetes-sigs/kustomize#5971): fix: performance recession when propagating namespace to helm [#5942](kubernetes-sigs/kustomize#5942): fix fnplugin storagemounts validation [#5958](kubernetes-sigs/kustomize#5958): fix: make AbsorbAll conflict error more verbose [#5961](kubernetes-sigs/kustomize#5961): refactor: nested format string [#5967](kubernetes-sigs/kustomize#5967): Fix infinite loop in HTTP client by validating URLs before requests [#5985](kubernetes-sigs/kustomize#5985): fix(kyaml/yaml): minor nil safety fix for RNode.Content etc [#5991](kubernetes-sigs/kustomize#5991): Fix duplicate key error when adding multiple labels with --without-selector #### Dependencies [#5962](kubernetes-sigs/kustomize#5962): chore: update dependencies from security alert [#5959](kubernetes-sigs/kustomize#5959): update go 1.24.6 #### chore [#6007](kubernetes-sigs/kustomize#6007): Update kyaml to v0.21.0 [#6008](kubernetes-sigs/kustomize#6008): Update cmd/config to v0.21.0 [#6009](kubernetes-sigs/kustomize#6009): Update api to v0.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

feat: Add regex support for Replacement selectors

8f75c39

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 16, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2025

k8s-ci-robot requested review from ncapps and stormqueen1990 February 16, 2025 13:55

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 16, 2025

sda399 closed this Apr 4, 2025

sda399 deleted the replacements_regex branch April 4, 2025 16:17

sda399 restored the replacements_regex branch April 4, 2025 17:39

Add new tests for regex support

f1af7ad

sda399 reopened this Apr 4, 2025

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2025

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 4, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2025

sda399 added 2 commits April 30, 2025 22:09

Earlier exit with rejectAny, and fix linting

dc0344b

Add example Use cases using regex

2a6481b

k8s-ci-robot assigned koba1t Aug 12, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025

k8s-ci-robot merged commit 7c04cbb into kubernetes-sigs:master Aug 12, 2025
11 checks passed

sda399 deleted the replacements_regex branch September 2, 2025 19:03

sda399 mentioned this pull request Sep 11, 2025

Add undocumented and new features to kustomize replacements doc kubernetes-sigs/cli-experimental#420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add regex support for Replacement selectors #5863

Add regex support for Replacement selectors #5863

sda399 commented Feb 16, 2025 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Feb 16, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

k8s-ci-robot commented Apr 4, 2025

Uh oh!

k8s-ci-robot commented Apr 4, 2025

Uh oh!

sda399 commented Apr 4, 2025

Uh oh!

koba1t commented Apr 30, 2025

Uh oh!

sda399 commented May 28, 2025 •

edited

Loading

Uh oh!

sda399 commented Jul 6, 2025

Uh oh!

koba1t commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Aug 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add regex support for Replacement selectors #5863

Add regex support for Replacement selectors #5863

Conversation

sda399 commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented Feb 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

k8s-ci-robot commented Feb 16, 2025

Uh oh!

k8s-ci-robot commented Apr 4, 2025

Uh oh!

k8s-ci-robot commented Apr 4, 2025

Uh oh!

sda399 commented Apr 4, 2025

Uh oh!

koba1t commented Apr 30, 2025

Uh oh!

sda399 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sda399 commented Jul 6, 2025

Uh oh!

koba1t commented Aug 12, 2025

Uh oh!

k8s-ci-robot commented Aug 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sda399 commented Feb 16, 2025 •

edited

Loading

linux-foundation-easycla bot commented Feb 16, 2025 •

edited

Loading

sda399 commented May 28, 2025 •

edited

Loading