Add static value source for replacement #5630

cunyat · 2024-03-28T19:30:50Z

Introduces sourceValue key on replacement for replacing from a static value instead of sourcing from another object.

linux-foundation-easycla · 2024-03-28T19:30:56Z

The committers listed above are authorized under a signed CLA.

✅ login: cunyat / name: Ramon Cuñat (6c27970)

k8s-ci-robot · 2024-03-28T19:30:58Z

Welcome @cunyat!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-03-28T19:30:59Z

Hi @cunyat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

varshaprasad96

@cnmcavoy Thanks for the PR! Just one nit, which would be nice to fix.

Also, looks like the linter is failing. It's not related to changes in this PR, but if we merge it without getting all the tests green then we would end up failing all the PRs. Could you please all fix it.

varshaprasad96 · 2024-06-12T17:35:09Z

api/filters/replacement/replacement.go

 }

 func getReplacement(nodes []*yaml.RNode, r *types.Replacement) (*yaml.RNode, error) {
+	if r.SourceValue != nil && r.Source != nil {


I think we already have check while reading yaml nodes to not allow nil while adding elements to Replacements list. But can we do an early return if r == nil to avoid nil pointers just in case?

Actually this can be done in Filter itself.

I don't know if I'm understanding it.
In Filter function, replacements is an slice of type []types.Replacement, so their elements should not be nil.
Inside getReplacement function, as I can see, it's passed by reference so it can modify the field path to the default one in case it is not given.
As I see it, inside the for loop on Filter function, r cannot be nil, don't know if I'm missing something, sorry 😅

I believe @varshaprasad96 care about getReplacement() is called other places and that is better to handle error instead of reference field in nil value.

But, This func is private and we have never checked that before.
I think acceptable this time and We can fix next PR.

varshaprasad96 · 2024-06-12T17:39:56Z

/ok-to-test

k8s-ci-robot · 2024-06-12T21:01:18Z

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Introduces `sourceValue` on replacement object for replacing from a static value instead of sourcing from another object. Solves kubernetes-sigs#5516

cunyat · 2024-07-25T12:33:48Z

@cnmcavoy Thanks for the PR! Just one nit, which would be nice to fix.

Also, looks like the linter is failing. It's not related to changes in this PR, but if we merge it without getting all the tests green then we would end up failing all the PRs. Could you please all fix it.

I've removed the commit fixing that test as it is already fixed in upstream

koba1t · 2024-09-12T22:28:20Z

HI @varshaprasad96
Can you recheck this PR?

ErwanDL · 2024-09-13T08:44:32Z

I deleted my previous comment (asking when this will be merged) upon further reflection. See #5063 (comment) for the rationale.

k8s-triage-robot · 2024-12-12T09:38:02Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

koba1t · 2024-12-17T19:43:15Z

/remove-lifecycle stale

k8s-triage-robot · 2025-03-17T19:43:46Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

koba1t · 2025-03-20T22:30:49Z

I'll check it.
/assign

koba1t · 2025-03-20T22:30:56Z

/remove-lifecycle stale

koba1t · 2025-03-28T12:45:01Z

@cunyat
Thanks for your contribution!

/lgtm
/approve

k8s-ci-robot · 2025-03-28T12:45:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cunyat, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.6.0` -> `v5.7.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.7.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.7.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.6.0...kustomize/v5.7.0) #### Feature kubernetes-sigs/kustomize#5630: Add static value source for replacement kubernetes-sigs/kustomize#5921: feat: Add images suport for Image Volumes kubernetes-sigs/kustomize#5771: fix: Allow patches with empty files with multiple newlines or comments kubernetes-sigs/kustomize#5865: feat(helm): allow the use of devel alias for helmcharts #### fix kubernetes-sigs/kustomize#5846: fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag kubernetes-sigs/kustomize#5859: fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file kubernetes-sigs/kustomize#5877: fix: make private one field in replacements transformer struct that had a missing JSON tag #### Dependencies [#5847](kubernetes-sigs/kustomize#5847): replace deplecated package github.com/google/shlex with github.com/carapace-sh/carapace-shlex [#5873](kubernetes-sigs/kustomize#5873): Bump to github.com/spf13/viper v1.20.0 [#5931](kubernetes-sigs/kustomize#5931): Drop usage of forked copies of goyaml.v2 and goyaml.v3 #### chore kubernetes-sigs/kustomize#5882: Set Git messages to English for TestRemoteLoad\_LocalProtocol [#5934](kubernetes-sigs/kustomize#5934): Update kyaml to v0.20.0 [#5935](kubernetes-sigs/kustomize#5935): Update cmd/config to v0.20.0 [#5936](kubernetes-sigs/kustomize#5936): Update api to v0.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

k8s-ci-robot requested review from koba1t and stormqueen1990 March 28, 2024 19:30

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2024

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 28, 2024

cunyat force-pushed the feat/5516-replacement-inline-value branch from ac70b7c to 53100b0 Compare June 12, 2024 07:47

varshaprasad96 reviewed Jun 12, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2024

cunyat requested a review from varshaprasad96 June 12, 2024 21:26

Add static value source for replacement

6c27970

Introduces `sourceValue` on replacement object for replacing from a static value instead of sourcing from another object. Solves kubernetes-sigs#5516

cunyat force-pushed the feat/5516-replacement-inline-value branch from 55977b9 to 6c27970 Compare July 25, 2024 12:33

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 17, 2025

k8s-ci-robot assigned koba1t Mar 20, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025

k8s-ci-robot merged commit 2e80ceb into kubernetes-sigs:master Mar 28, 2025
2 checks passed

koba1t mentioned this pull request Jul 9, 2025

Replacements should support an inline value as a source #5516

Closed

2 tasks

VannTen mentioned this pull request Aug 29, 2025

Document sourceValue for replacements. #5974

Open

sda399 mentioned this pull request Sep 7, 2025

Add undocumented and new features to kustomize replacements doc kubernetes-sigs/cli-experimental#420

Merged

Add static value source for replacement #5630

Add static value source for replacement #5630

Conversation

cunyat commented Mar 28, 2024

Uh oh!

linux-foundation-easycla bot commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

k8s-ci-robot commented Mar 28, 2024

Uh oh!

varshaprasad96 left a comment

Choose a reason for hiding this comment

Uh oh!

varshaprasad96 Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

varshaprasad96 Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

cunyat Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

koba1t Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

varshaprasad96 commented Jun 12, 2024

Uh oh!

k8s-ci-robot commented Jun 12, 2024

Uh oh!

cunyat commented Jul 25, 2024

Uh oh!

koba1t commented Sep 12, 2024

Uh oh!

ErwanDL commented Sep 13, 2024

Uh oh!

k8s-triage-robot commented Dec 12, 2024

Uh oh!

koba1t commented Dec 17, 2024

Uh oh!

k8s-triage-robot commented Mar 17, 2025

Uh oh!

koba1t commented Mar 20, 2025

Uh oh!

koba1t commented Mar 20, 2025

Uh oh!

koba1t commented Mar 28, 2025

Uh oh!

k8s-ci-robot commented Mar 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

linux-foundation-easycla bot commented Mar 28, 2024 •

edited

Loading