Update fork #4
Merged
Update fork #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a message to the exception thrown when using an invalid light mode. Converted it to an IOException instead of the UnsupportedOperationException (which is a runtime exception) so that the calling code will output a meaningful error about which asset actually failed.
test and fix for JME issue #954 (null bounding volume)
that can optionally throw an exception if the state does not exist.
Added AppStateManager.getState(class, failOnMiss)
) * Added a (hacky) fix for a Java Swing/AWT + GLFW interaction issue… … on Linux. * Added a proper comment * Added an extra call to System.gc() as recommendation from lwjgl’s @Spasi "Run System.gc(), at least two times. Not sure how AWT handles native resources, maybe there’s a finalizable/PhantomRef-ed resource that is not released immediately, but a subsequent GC triggers a (too late) free. "
* Added an easy way to add sub steps to the profiler and enhanced the App State Manager to profile the update method of each app state * Added the profiler step to the android profiler * Fixed missing profiler extensions
* returns an unmodifiable set when retrieving the available animation names and available animation clips instead of an unmodifiable collection. fixes: #1070 * remove unnecessary set wrapper. * Remove the unnecessary creation of a new hashset everytime getAnimClips() is called.
* Added ambient light support in PBR shader * Updated to auto inject the define value if ambient light found
Fixing the broken build. Thanks to @Ali-RS for providing the hint: https://travis-ci.community/t/install-of-openjdk11-is-failing-again/3061/16
…ith Layer cloning (#1080) * AnimComposer: save globalSpeed on export * Updated TestModelExportingCloning to test AnimComposer.globalSpeed * Fixed issue with AnimComposer.Layer cloning
Fixes bug causing NullPointerException when removing joysticks. Allows adding joysticks after the application has started.
Set the logger to the correct class
Set methods to use JoystickState enum instead of event integers.
Use separate connection methods (onConnected/onDisconnected).
Add support for listening to joystick connection/disconnection.
Add support for fog in materials.
joliver82
pushed a commit
that referenced
this pull request
Oct 7, 2024
* coding style improvements + use curly braces where optional (4.1.1) + indent continuation lines by +8 (4.5.2) + no single space after an open paren or before a close paren (4.6.2) + no single space before an unary operator (4.6.2) + no single space before a square bracket (4.6.2) + single space before "else" (4.6.2 #2) + single space before an open curly brace (4.6.2 #3) + single space around a binary or ternary operator (4.6.2 #4) + single space after a comma (4.6.2 #5) * coding style improvements: no wildcard imports (3.3.1) * RenderContext: import ordering and spacing (3.3.3) * wrap lines that exceed 110 characters * single variable per declaration (4.8.2.1) * Caps: mark fallthrough with comments (4.8.4.2) * RenderContext: "static" before "final" (4.8.7) * constant names use CONSTANT_CASE (5.2.4) Note: **API change** * ignore acronyms in camel case (5.3) Note: **API change** * improve the javadoc style: + paragraphs separated by a blank line (7.1.2) + successive paragraphs start with "<p>" (7.1.2) + javadoc blocks begin with a summary fragment, not a sentence (7.2) + summary not in imperative mood (7.2) + summary capitalized and punctuated like a sentence (7.2) * Renderer: re-order block tags (7.1.3) * indent block-tag continuations by at least +4 (7.1.3) * one blank line before the first block tag (7.1.3) * correct indentation of javadoc in 2 places (7.1.1) * TestIDList: ignore acronyms in camel case (5.3) * revisit the javadoc style, reverting portions of e763ecb * one annotation per line (4.8.5) * add required javadoc (7.3) * Camera: blank line before the first block tag (7.1.2) * Camera: revert an unintented change * Camera: change "Determines" to "Returns" in 2 places * no trailing spaces * revert API changes * convert comment to javadoc and add missing javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.