Added ambient light support in PBR shader #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This uses a cleaner solution over my previous PR: #1075 |
This was referenced Apr 25, 2019
Member
|
This will also be very useful for lowering probe intensity so that the point lights stand out more. On the other hand, what happened with the indent formatting in the shader file? |
Member
Author
Afew of them had no indent, some had 5 and most of them had 2, so I updated others to use 2 spaces. Do not know what is the standard for shader so. Even Netbeans formatter not helped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to control the brightness and color of the light probe. Very useful for simulating day/night light and any use case where you don't rebake the probes every time the ambient color needs to change.