Skip to content

Conversation

@stephengold
Copy link
Member

Implementation for PhysicsCharacter will be a separate PR.

@riccardobl
Copy link
Member

riccardobl commented Dec 5, 2018

I know i was the one who suggested the name for this method, but on second thought i think it would be better (more descriptive) to invert the logic and call it setIgnoreContactResponse or setNoContactResponse so that it mirrors the flag name.

Also i think hard coded flags should be avoided, by either doing this or by making set(No|Ignore)ContactResponse native.

@stephengold
Copy link
Member Author

Riccardo: Thanks for reviewing this PR. I appreciate your help.

While I see value in being consistent with the flag name, I'm reluctant to alter the method names because of the extra mental effort to interpret "set ignore" or "set not" as compared with "set".

I agree that hardcoded flag values are undesirable. That was lazy of me. I'll address it before integrating this PR.

I've also decided that isContactResponse() should be a PhysicsCollisionObject method rather than just a PhysicsRigidBody one, so I need to update this PR anyway. (The setter will remain specific to PhysicsRigidBody.)

@stephengold stephengold merged commit cf33c3c into jMonkeyEngine:master Dec 8, 2018
@stephengold
Copy link
Member Author

In the process of testing load/save/clone, I came across some unrelated bugs in jme3-bullet, but I'm satisfied that load/save/clone work for contact response. Once I've documented those issues, I'll look at PhysicsCharacter.

@stephengold stephengold added this to the v3.3.0 milestone Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants