Skip to content

Register thermal data cleanup at exit#20

Closed
jianyuewu wants to merge 1 commit intomasterfrom
thermal_data_cleanup
Closed

Register thermal data cleanup at exit#20
jianyuewu wants to merge 1 commit intomasterfrom
thermal_data_cleanup

Conversation

@jianyuewu
Copy link
Copy Markdown
Owner

Why I did it

Thermal data was being cleared at startup. we want it cleared on process exit to avoid wiping metrics on launch and ensure a clean shutdown behavior.

How I did it

Register an atexit callback that calls clean_thermal_data with the SFP list, removing the startup-time invocation.

How to verify it

UT and startup, shutdown test.

Which release branch to backport (provide reason below if selected)

  • 202511

Tested branch (Please provide the tested image version)

202511

@jianyuewu jianyuewu changed the title Thermal data cleanup Register thermal data cleanup at exit Dec 16, 2025
@jianyuewu jianyuewu force-pushed the thermal_data_cleanup branch 5 times, most recently from 9cc1606 to 1c26bc9 Compare December 16, 2025 10:28
@jianyuewu jianyuewu requested a review from keboliu December 16, 2025 15:02
jianyuewu pushed a commit that referenced this pull request Dec 18, 2025
…tically (sonic-net#694)

#### Why I did it
src/sonic-sairedis
```
* 23aa00d - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-sairedis:202411 to 202412 (#20) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit that referenced this pull request Dec 18, 2025
…tomatically (sonic-net#724)

#### Why I did it
src/sonic-linux-kernel
```
* 000051a - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#20) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit that referenced this pull request Dec 18, 2025
…omatically (sonic-net#747)

#### Why I did it
src/sonic-swss-common
```
* 9b5d2cf - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#20) (34 seconds ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
jianyuewu pushed a commit that referenced this pull request Dec 18, 2025
…UT so that we can get back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (sonic-net#1144)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it

Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup:
```
Moby1 Moby2
HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT
#17 <-> #18
#19 <-> #20
#21 <-> #22
#23 <-> #24

#18 <-> #17
#20 <-> #19
#22 <-> #21
#24 <-> #23
```

#### How to verify it
Verified that all the Paladin ports can link up with the above setup.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [x] msft-202412

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
- [x] msft-202412

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config.

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
jianyuewu pushed a commit that referenced this pull request Dec 18, 2025
…test HEAD automatically (sonic-net#1246)

#### Why I did it
src/sonic-platform-daemons
```
* c6f5f57 - (HEAD -> 202412, origin/202412) xcvrd: Remove SFP API object when SFP is removed (#22) (9 hours ago) [mssonicbld]
* a68c977 - Add Robust Exception Handling to pcied Daemon for Improved Stability (sonic-net#618) (#20) (2 days ago) [Vasundhara Volam]
```
#### How I did it
#### How to verify it
#### Description for the changelog
@jianyuewu jianyuewu force-pushed the thermal_data_cleanup branch 3 times, most recently from ac481fe to b8237b7 Compare December 23, 2025 11:09
Register atexit callback to clean thermal data on process shutdown.
Only cleanup SW control modules.

Signed-off-by: Jianyue Wu <jianyuew@nvidia.com>
@jianyuewu jianyuewu closed this Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants