Thermal algo enhancement and vendor info update#18
Closed
Conversation
Background: In parallel to the thermal_updator and the hw-managemen-sync-service, the thermalctrld read also the sensors temperature and sensors thresholds. All the above entity reading module temperature over I2C, need to be avoided. Also reading the same information by different entity affect CPU utilization. In SW mode: Keep as it is. In FW mode: Sonic also will be responsible for reading SDK and update hw-management sysfs. Changes are: Read module temperature/threshold from sdk sysfs. Add cache in FW mode when get temperature info. Disable hw-mgmt sync service. Thermal platform API read from /var/run/hw-management/ files directly. Add a maximum attempt limit to reduce unnecessary retry time. Add sysfs readiness for thermal updater. Remove asics_init_done dependency from platform ready check. Signed-off-by: Jianyue Wu <[email protected]>
Signed-off-by: Jianyue Wu <[email protected]>
Signed-off-by: Jianyue Wu <[email protected]>
On first detection or module replacement, if the serial number (SN) has changed, call vendor_data_set_module() with the manufacturer (MFG) and part number (PN) to send the vendor info to hw-management. Sample output like: NOTICE pmon#thermalctld: Module 0 vendor info updated \ - manufacturer: NVIDIA part_number: MCP4Y10-N001 Signed-off-by: Jianyue Wu <[email protected]>
Register clean_thermal_data() with atexit in start() instead of calling it directly. This moves thermal data cleanup from initialization to termination, ensuring proper cleanup when thermalctld exits. Signed-off-by: Jianyue Wu <[email protected]>
jianyuewu
pushed a commit
that referenced
this pull request
Dec 18, 2025
…tically (sonic-net#682) #### Why I did it src/sonic-sairedis ``` * 2e00768 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-sairedis:202411 to 202412 (#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
jianyuewu
pushed a commit
that referenced
this pull request
Dec 18, 2025
…omatically (sonic-net#705) #### Why I did it src/sonic-swss-common ``` * 0d42e0a - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #19 from r12f/code-sync-202412 (18 hours ago) [Riff] |\ | failure_prs.log skip_prs.log 3fa36f4 - Merge remote-tracking branch 'base/202411' into code-sync-202412 (19 hours ago) [r12f] |/| | failure_prs.log skip_prs.log 7aa1a47 - Added field for policer counter (sonic-net#975) (7 days ago) [mssonicbld] | failure_prs.log skip_prs.log 8f47a37 - Handle 'bulkget' in consumer_table_pops.lua (sonic-net#970) (3 weeks ago) [mssonicbld] * 3f09bf0 - [code sync] Merge code from sonic-net/sonic-swss-common:202411 to 202412 (#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
jianyuewu
pushed a commit
that referenced
this pull request
Dec 18, 2025
…tomatically (sonic-net#704) #### Why I did it src/sonic-linux-kernel ``` * 6877ae3 - (HEAD -> 202412, origin/HEAD, origin/202412) [optoe] Reset page select byte to 0 before upper memory access on page 0h (sonic-net#464) (#18) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
jianyuewu
pushed a commit
that referenced
this pull request
Dec 18, 2025
…UT so that we can get back to back Paladin ports up with Arista-7060X6-16PE-384C-O128S2 (sonic-net#1144) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Currently when we loaded HWSKU `Arista-7060X6-16PE-384C-O128S2` on two moby devices and connect their Paladin ports back to back, we can't get link up. It may help if we can get these links up and run the tests. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Created a new `FANOUT` HWSKU containing special lanemap and polarity configs so that we can load `Arista-7060X6-16PE-384C-O128S2` on one Moby and `Arista-7060X6-16PE-384C-O128S2-FANOUT` and get Paladin ports up when connecting them back to back with the following setup: ``` Moby1 Moby2 HWSKU: Arista-7060X6-16PE-384C-O128S2 HWSKU: Arista-7060X6-16PE-384C-O128S2-FANOUT #17 <-> #18 #19 <-> #20 #21 <-> #22 #23 <-> #24 #18 <-> #17 #20 <-> #19 #22 <-> #21 #24 <-> #23 ``` #### How to verify it Verified that all the Paladin ports can link up with the above setup. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 - [x] msft-202412 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> Created `Arista-7060X6-16PE-384C-O128S2-FANOUT` based on `Arista-7060X6-16PE-384C-O128S2` and only update lanemap and polarity settings in bcm config. <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
jianyuewu
pushed a commit
that referenced
this pull request
Dec 18, 2025
…tomatically (sonic-net#1498) #### Why I did it src/sonic-gnmi ``` * 3679372 - (HEAD -> 202412, origin/202412) Add SHOW implementation for interface transceiver error-status. (#18) (4 hours ago) [mssonicbld] * 45d679a - Add show watermark telemetry interval implementation (#16) (19 hours ago) [mssonicbld] * 57d0b6f - Simplify option support for all SHOW paths (#15) (23 hours ago) [mssonicbld] * 7dd2615 - Add support for show int error (#14) (24 hours ago) [mssonicbld] * d8e0216 - Add SHOW implementation for interface counters (#11) (25 hours ago) [mssonicbld] * 6c56f41 - [202412] Manual cherrypick for adding support for RATES tables in Counters DB so that PRE_FEC/POST_FEC_BER via ST (#13) (26 hours ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings.
This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes.
How I did it
Implemented new API for vendor-specific temperature offset adjustments:
New API:
Smart Module Detection:
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202412
A picture of a cute animal (not mandatory but encouraged)