Merge Release/v0.6.6 into release 0.6.5

[louis-jan]

Describe Your Changes

This commit adds responsive fix commits to version 0.6.5, incorporating some of the changes made on the development branch.

Fixes Issues

• Closes #
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Enhances settings and provider management, adds E2E tests, and improves UI components in the web app.

• Settings and Providers:
  • Adds SettingsMenu and ProvidersMenu components for better navigation in Settings.
  • Introduces ModelProviders and ProviderDetail routes for managing model providers.
  • Updates SettingsMenu to include a submenu for model providers.
  • Adds SettingsProvidersIndexRoute and SettingsProvidersProviderNameRoute in routeTree.gen.ts.
• E2E Testing:
  • Adds E2E test setup in tests-e2e-js with selenium-webdriver and @tauri-e2e/selenium.
  • Implements a basic test in main.ts to check for the presence of the hub menu.
• UI Enhancements:
  • Updates CardItem in Card.tsx to support descriptionOutside and classNameWrapperAction.
  • Modifies ChatInput.tsx to include data-test-id attributes for testing.
  • Adjusts ChatWidthSwitcher.tsx for better layout on small screens.
  • Refines LeftPanel.tsx to handle screen size changes and improve thread management.
• Miscellaneous:
  • Updates package.json in web-app to include new dependencies and scripts.
  • Adjusts routeTree.gen.ts to reflect new routes and settings.

^{This description was created by for dc4e592. You can customize this summary. It will automatically update as commits are pushed.}

[github-actions]

Preview URL: https://05d3b526.docs-9ba.pages.dev

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to dc4e592 in 3 minutes and 6 seconds. Click for details.

• Reviewed 2496 lines of code in 55 files
• Skipped 8 files when reviewing.
• Skipped posting 19 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/ChatInput.tsx:16

• Draft comment:
  Please remove the unprofessional ts-ignore comment ("// @ts-ignore fuck you javascript") and replace it with proper typing or a benign comment. Avoid profanity in code comments.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. web-app/src/containers/SettingsMenu.tsx:142

• Draft comment:
  Using a Link element to toggle the sub-menu may mix navigation with UI toggle behavior. Consider using a dedicated button for toggling the providers sub‐menu to improve accessibility and semantics.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% The comment suggests separating the Link and toggle functionality, but looking at the implementation, they are already properly separated. The Link handles navigation, while a separate button element inside handles the toggle with proper event handling to prevent conflicts. This is actually a good pattern that maintains both navigation and toggle functionality in an accessible way. I could be missing some accessibility best practices. Maybe there's a better way to structure this that I'm not aware of. The current implementation already follows good practices by using semantic HTML elements (Link for navigation, button for interaction) and proper event handling to prevent conflicts. The comment should be deleted because the code already implements a proper separation between navigation and toggle functionality using appropriate semantic elements.

3. web-app/src/routes/settings/general.tsx:215

• Draft comment:
  The app version is displayed as 'v{VERSION}' but VERSION is not imported or defined in this file. Ensure VERSION is provided via an environment variable or global constant and document its source.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. web-app/src/routes/settings/mcp-servers.tsx:26

• Draft comment:
  The maskSensitiveValue function masks any value 8 characters or shorter completely. Confirm that this behavior is intended and consider handling very short sensitive values appropriately.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. web-app/src/routes/settings/mcp-servers.tsx:86

• Draft comment:
  In handleSaveServer, toggleServer is called before updating server settings. Consider awaiting these async calls in sequence to avoid potential race conditions.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. web-app/src/routes/settings/providers/$providerName.tsx:267

• Draft comment:
  When handling dynamic controller settings, ensure that updates are performed immutably (e.g., using cloneDeep) to avoid unintentional state mutation. Verify that the updated settings work as expected.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. web-app/src/routes/settings/providers/index.tsx:41

• Draft comment:
  After adding a new provider, a setTimeout with 0 delay is used to navigate. Consider handling navigation in a useEffect or after ensuring the provider update completes to avoid potential timing issues.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While setTimeout(0) can sometimes indicate timing issues, here it seems to be used deliberately to defer navigation to the next tick. Without seeing the implementation of addProvider or knowing if it's async, it's hard to say if this is actually problematic. The code appears to be working as intended - the navigation is intentionally deferred. I may be too quick to dismiss the timing concern. Race conditions can be subtle and hard to detect during testing. However, the suggestion to use useEffect seems inappropriate here since this is an event handler. Without clear evidence of an actual problem, this seems like speculation. The comment is speculative and suggests changes without clear evidence of an actual problem. The current implementation may be intentional.

8. web-app/src/routes/threads/$threadId.tsx:184

• Draft comment:
  The debounced scroll handler is set up without explicit cancellation in some effects. Confirm that the debounce instance is properly cleaned up to prevent memory leaks.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. web-app/src/containers/ChatInput.tsx:390

• Draft comment:
  Several data attributes (e.g., data-test-id) are hard-coded for testability – ensure these do not leak into production builds if not needed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. web-app/src/routes/settings/general.tsx:87

• Draft comment:
  Multiple useEffects disable exhaustive-deps linting. Revisit these dependency arrays to ensure no stale closures or unexpected behavior occur.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. web-app/src/routes/settings/local-api-server.tsx:49

• Draft comment:
  When validating the API key before starting the local API server, the error state is toggled. Consider adding more detailed error feedback or logging for debugging purposes.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

12. web-app/src/routes/settings/mcp-servers.tsx:167

• Draft comment:
  In toggleServer, backend invocations (activate/deactivate) via 'invoke' are used. Ensure proper error handling and consider whether additional retry logic or user feedback is needed.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

13. web-app/src/routes/settings/providers/$providerName.tsx:55

• Draft comment:
  Joyride steps use CSS selectors (e.g., '.first-step-setup-remote-provider'). Ensure these class names are stable and documented, since any change might break the guided tour.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

14. web-app/src/routes/threads/$threadId.tsx:151

• Draft comment:
  Auto-scroll logic uses several useEffects and a debounced scroll handler. Verify that these interactions (especially with streaming content) do not cause jank or unexpected scrolling behavior on low-performance devices.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

15. web-app/src:0

• Draft comment:
  Throughout the code, several global constants (e.g., IS_MACOS, IS_WINDOWS, IS_LINUX, VERSION) are used but not clearly imported or defined. Ensure that these globals are defined in a central location and documented for maintainability and clarity.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

16. docs/src/pages/docs/data-folder.mdx:220

• Draft comment:
  The Linux uninstall guide link appears to be missing a leading slash. For consistency with the Mac and Windows links, consider changing (docs/desktop/linux#uninstall-jan) to (/docs/desktop/linux#uninstall-jan).
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

17. src-tauri/src/core/setup.rs:286

• Draft comment:
  The raw string literal in the replace call seems off: r"\?" may be incorrectly terminated because a raw string literal in Rust cannot end with a backslash. Did you mean to use r"\?\" or adjust it using alternative raw string syntax (e.g., r#"\?"#) to correctly match the intended pattern?
• Reason this comment was not posted:
  Comment was on unchanged code.

18. web-app/src/containers/ChatInput.tsx:572

• Draft comment:
  Typo: The function 'handleSendMesage' seems to have a misspelling. Did you mean 'handleSendMessage'?
• Reason this comment was not posted:
  Comment was on unchanged code.

19. web-app/src/containers/ChatWidthSwitcher.tsx:15

• Draft comment:
  There's an extra trailing space at the end of the class string ('w-full overflow-hidden border border-main-view-fg/10 rounded-md my-2 pb-2 cursor-pointer '). Consider removing it for consistency.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct and points out an actual inconsistency, trailing spaces in className strings in React/JSX have no effect on the rendered output. This is an extremely minor formatting issue that doesn't affect functionality or maintainability. The comment feels overly pedantic. The trailing space could be a sign of sloppy code maintenance and inconsistent formatting. Consistent formatting helps maintain code quality. While consistency is good, this is too minor to warrant a comment. Most teams would consider this level of nitpicking to be noise that distracts from more important review feedback. Delete this comment as it's too minor and doesn't meaningfully impact code quality or maintainability.

Workflow ID: wflow_cgHjDvP3pik86Pay

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}