Skip to content

Conversation

@urmauur
Copy link
Member

@urmauur urmauur commented Jul 7, 2025

Describe Your Changes

Screenshot 2025-07-05 at 17 37 28
Screenshot 2025-07-05 at 17 37 21

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Improves UI interaction in DownloadManagement.tsx and ThreadList.tsx by adding right-click dropdowns and adjusting layout.

  • Behavior:
    • ThreadList.tsx: Adds right-click event to open dropdown menu for threads using onContextMenu.
    • DownloadManagement.tsx: Adjusts UI layout for download count and progress display.
  • UI Changes:
    • DownloadManagement.tsx: Moves download count inside a flex container and adjusts spacing.
    • ThreadList.tsx: Removes redundant class from IconDots and adjusts dropdown menu trigger behavior.
  • Misc:
    • Fixes formatting and spacing issues in DownloadManagement.tsx and ThreadList.tsx.

This description was created by Ellipsis for 2ac8466. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.5 milestone Jul 7, 2025
@urmauur urmauur requested a review from louis-jan July 7, 2025 03:20
@urmauur urmauur self-assigned this Jul 7, 2025
@urmauur urmauur added this to Jan Jul 7, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2ac8466 in 1 minute and 44 seconds. Click for details.
  • Reviewed 92 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/DownloadManegement.tsx:277
  • Draft comment:
    The onFocusOutside handler does not invoke preventDefault; it returns the function reference instead of calling it. Please update it to call the function, e.g., onFocusOutside={(e) => { e.preventDefault(); }}.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. web-app/src/containers/ThreadList.tsx:304
  • Draft comment:
    It’s recommended to use a stable, unique key (e.g. thread.id) instead of the index when mapping through threads, to avoid potential rendering issues.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. web-app/src/containers/ThreadList.tsx:130
  • Draft comment:
    The removal of conditional size classes from IconDots ensures the three dots icon is always visible, which addresses issue 5409. Confirm this change meets the design requirements across different hover and touch interactions.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
4. web-app/src/containers/ThreadList.tsx:108
  • Draft comment:
    The addition of an onContextMenu handler to open the dropdown is a useful enhancement for touch and right-click interactions. Please ensure that suppressing the default context menu does not negatively impact accessibility or expected browser behavior.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. web-app/src/containers/DownloadManegement.tsx:317
  • Draft comment:
    Typo: The file name (DownloadManegement.tsx) appears to be misspelled. Consider renaming it to DownloadManagement.tsx to match the component name and common spelling.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. web-app/src/containers/ThreadList.tsx:114
  • Draft comment:
    There appears to be an extra space between 'px-1.5' and 'transition-all' in the className string. Consider removing the extra space for consistency.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about the extra space, this is an extremely minor formatting issue. The extra space in the className string won't affect functionality since HTML/CSS class names are space-delimited anyway. This feels like nitpicking that doesn't add value to the code review. The extra space could be a sign of inconsistent code formatting that might accumulate over time. It's a small issue but could be worth fixing for maintainability. While consistency is good, this is too minor to warrant a comment. Most teams would handle this kind of formatting with automated tools like Prettier rather than manual code review comments. Delete this comment as it's too minor and doesn't provide meaningful value to the code review. This kind of formatting issue should be handled by automated tools.

Workflow ID: wflow_Bg7W1rL3ApDo61Ox

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur moved this to Needs Review in Jan Jul 7, 2025
* ✨enhancement: enable resizable left panel

* Update web-app/src/hooks/useLeftPanel.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@urmauur urmauur merged commit 1422d94 into release/v0.6.6 Jul 7, 2025
2 checks passed
@urmauur urmauur deleted the fix/three-dots branch July 7, 2025 04:14
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Jul 7, 2025
@urmauur urmauur moved this from QA to Done in Jan Jul 10, 2025
@LazyYuuki LazyYuuki mentioned this pull request Jul 14, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug: "Three dots" don't appear on thread title hover - possibly on touch screen windows

2 participants