-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore: deprecate ci environment #5592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Related issue #5453 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to a4e8a34 in 1 minute and 12 seconds. Click for details.
- Reviewed
133lines of code in7files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/publish-npm-core.yml:9
- Draft comment:
Removed 'environment: production' from the 'build-and-publish-plugins' job. Ensure that any required production approval or gating is handled elsewhere. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure that production approval or gating is handled elsewhere, which violates the rule against asking the author to ensure behavior is intended or tested. It doesn't provide a specific code suggestion or ask for a specific test to be written.
2. .github/workflows/template-electron-build-linux-x64.yml:44
- Draft comment:
Removed 'environment: production' from the 'build-linux-x64' job to simplify the workflow configuration. This change is consistent with updated practices. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining a change that was made without asking for any specific action or providing a suggestion. It doesn't align with the rules for useful comments.
3. .github/workflows/template-electron-build-macos.yml:54
- Draft comment:
Removed 'environment: production' from the 'build-macos' job. The change aligns with updated workflow standards. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining a change that was made without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest any improvements.
4. .github/workflows/template-get-update-version.yml:10
- Draft comment:
Removed 'environment: production' from the 'get-update-version' job. Verify that any intended access controls are maintained elsewhere. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to verify that access controls are maintained elsewhere after a change. This falls under asking the author to ensure behavior is intended, which is against the rules.
5. .github/workflows/template-noti-discord-and-update-url-readme.yml:28
- Draft comment:
Removed 'environment: production' from the 'noti-discord-and-update-url-readme' job to streamline the workflow configuration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining a change made in the code without providing any actionable feedback or suggestions. It does not align with the rules for useful comments.
6. .github/workflows/template-tauri-build-linux-x64.yml:56
- Draft comment:
Removed 'environment: production' from the tauri Linux build job. This removal simplifies the configuration and is consistent with other workflows. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, explaining a change made in the PR without suggesting any action or asking for clarification. It doesn't align with the rules for useful comments.
7. .github/workflows/template-tauri-build-macos.yml:64
- Draft comment:
Removed 'environment: production' from the tauri macOS build job. Confirm that any environment-specific approvals or controls are addressed as needed. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm that environment-specific approvals or controls are addressed, which violates the rule against asking for confirmation or ensuring behavior is intended. It does not provide a specific code suggestion or ask for a specific test to be written.
Workflow ID: wflow_JZwNL7TDLQCE9rzp
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
louis-jan
approved these changes
Jun 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
environment: productionsetting from several GitHub Actions workflows. These changes simplify the configuration and align the workflows with updated practices.Workflow configuration updates:
.github/workflows/publish-npm-core.yml: Removedenvironment: productionfrom thebuild-and-publish-pluginsjob configuration..github/workflows/template-electron-build-linux-x64.yml: Removedenvironment: productionfrom thebuild-linux-x64job configuration..github/workflows/template-electron-build-macos.yml: Removedenvironment: productionfrom thebuild-macosjob configuration..github/workflows/template-get-update-version.yml: Removedenvironment: productionfrom theget-update-versionjob configuration..github/workflows/template-noti-discord-and-update-url-readme.yml: Removedenvironment: productionfrom thenoti-discord-and-update-url-readmejob configuration.Important
Remove
environment: productionfrom multiple GitHub Actions workflows to simplify configuration.environment: productionfrombuild-and-publish-pluginsinpublish-npm-core.yml.environment: productionfrombuild-linux-x64intemplate-electron-build-linux-x64.yml.environment: productionfrombuild-macosintemplate-electron-build-macos.yml.environment: productionfromget-update-versionintemplate-get-update-version.yml.environment: productionfromnoti-discord-and-update-url-readmeintemplate-noti-discord-and-update-url-readme.yml.This description was created by
for a4e8a34. You can customize this summary. It will automatically update as commits are pushed.