Merged
Conversation
1b4ca4c to
3de1e7e
Compare
b39d8e7 to
ada7c22
Compare
ada7c22 to
3eea809
Compare
Collaborator
Author
|
Last commit need to be fixed a little, fix in |
3eea809 to
60f4819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a big deal, but wanted keep at actual stage for development.
istanbulremoved, if coverage will be required will need add scripts and addnycas dependencysemistandardupdated and new error messages fixes, probably new version will out soon (newstandardversion was released 2 days ago)mochaupdated, nothing changedAdded
yarn.lockfor locking dev dependencies, travis now install dependencies withyarn.Node.js versions in travis config updated, it's not possible keep 7,9 because one of dependencies of dependencies have restrictions in
enginesfield, details: https://travis-ci.org/fanatid/bn.js/builds/555443389Version 6 is not possible, because
assertpackage at that time did not hadstrictversion (require('assert').strict). I think it's possible to solve by usingstrictEqualand other, but is this matter run tests on version 6?Going squash and merge after 24h if there will no NACKs.